Re: [gtk-vnc-devel] PATCH: Portability to compile under MinGW for Windows

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Oct 09, 2008 at 01:03:11PM +0100, Richard W.M. Jones wrote:
> On Wed, Oct 08, 2008 at 07:52:50PM +0100, Daniel P. Berrange wrote:
> > +modules='
> > +getaddrinfo
> > +vc-list-files
> > +'
> 
> This didn't quite work for me.  I'm not sure if it's because we're
> using different versions of gnulib (I'm using the absolute latest
> version).  But I also needed the following modules to be added to the
> above list:
> 
>   recv
>   send
>   socket
>   connect

That shouldn't be needed - they're all provided by winsock, and
the neccessary header is included by sockcompat.h. So I thing
something else must have gone wrong. libvirt doesn't use those
modules either

> These modules are all LGPLv2+ so there should be no problem with
> adding them.
> 
> A second issue is that the socketcompat.h header (copied from libvirt)
> redefines some symbols which Gnulib's errno.h header now defines.
> Specifically the five redefined error numbers.  Patch to fix this is
> attached.  I'm fairly sure that the whole of socketcompat.h could be
> removed and replaced with Gnulib headers.

I imagine that's because of the extra recv/send/socket/connect modules
you've pulled in. Those errno defines are definitely required when
I compiled it using winsock.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|