[gnome-es] [Bug 741873] spanish translations of Epiphany's help breaks the build



https://bugzilla.gnome.org/show_bug.cgi?id=741873
  l10n | Spanish [es] | unspecified

--- Comment #10 from Shaun McCance <shaunm gnome org> 2014-12-23 19:03:17 UTC ---
The trouble is, the way it's implemented, it checks uniqueness at the wrong
time. Take this document:

<root>
  <node xml:id="myid">foo</node>
</root>

Get a reference to the node element. Create a new element that looks like this:

<node xml:id="myid">bar</node>

Then call:

xmlReplaceNode(oldnode, newnode);

Logically, this isn't adding a conflicting id. But xmlReplaceNode calls
xmlSetTreeDoc on newnode before oldnode is fully removed from the document.
That gives us an error, because the to-be-removed node with the same id isn't
yet removed. If you're going to go down this path, then you probably need to
recursively dig into oldnode calling xmlRemoveID before calling xmlSetTreeDoc
on newnode.

There's an added issue here of throwing validity (not well-formedness) errors
on non-validating code paths. But even if I want validity checks, the above
issue should be addressed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]