[glib/wip/pwithnall/2781-desktop-app-info-proc-bsd] tests: Temporarily disable desktop-app-info terminal test on FreeBSD
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/wip/pwithnall/2781-desktop-app-info-proc-bsd] tests: Temporarily disable desktop-app-info terminal test on FreeBSD
- Date: Tue, 18 Oct 2022 09:47:58 +0000 (UTC)
commit 3235eee0e2c75f746f14f95e58220b95a74ad3a6
Author: Philip Withnall <pwithnall endlessos org>
Date: Tue Oct 18 10:35:17 2022 +0100
tests: Temporarily disable desktop-app-info terminal test on FreeBSD
It’s often (but not always) failing on the CI machines with a timeout
which looks like the FD sharing via `/proc` isn’t reliably working.
Disable this test (but not the whole `desktop-app-info` test suite) on
FreeBSD until someone who has access to a FreeBSD machine can debug it.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
Helps: #2781
gio/tests/desktop-app-info.c | 7 +++++++
1 file changed, 7 insertions(+)
---
diff --git a/gio/tests/desktop-app-info.c b/gio/tests/desktop-app-info.c
index f49db4af7d..81804a8160 100644
--- a/gio/tests/desktop-app-info.c
+++ b/gio/tests/desktop-app-info.c
@@ -1182,6 +1182,7 @@ test_id (void)
g_free (result);
}
+#if !defined(__FreeBSD__)
static const char *
get_terminal_divider (const char *terminal_name)
{
@@ -1208,10 +1209,15 @@ get_terminal_divider (const char *terminal_name)
g_return_val_if_reached (NULL);
}
+#endif
static void
test_launch_uris_with_terminal (gconstpointer data)
{
+#if defined(__FreeBSD__)
+ /* FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/2781 */
+ g_test_skip ("/proc pipe sharing currently doesn’t work reliably on FreeBSD CI");
+#else
int fds[2];
const char *terminal_exec = data;
char *old_path;
@@ -1337,6 +1343,7 @@ test_launch_uris_with_terminal (gconstpointer data)
g_clear_error (&error);
g_clear_list (&paths, NULL);
g_clear_list (&uris, g_free);
+#endif
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]