[gnote] Move semantics for add_app_action



commit 19099615ab9162290c51183013aa4d13cd0d98b2
Author: Aurimas Černius <aurisc4 gmail com>
Date:   Mon Mar 28 17:15:14 2022 +0300

    Move semantics for add_app_action

 src/actionmanager.cpp  | 4 ++--
 src/actionmanager.hpp  | 2 +-
 src/iactionmanager.hpp | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/actionmanager.cpp b/src/actionmanager.cpp
index bd9200d0..b9e9a096 100644
--- a/src/actionmanager.cpp
+++ b/src/actionmanager.cpp
@@ -110,9 +110,9 @@ namespace gnote {
     return Glib::RefPtr<Gio::SimpleAction>();
   }
 
-  Glib::RefPtr<Gio::SimpleAction> ActionManager::add_app_action(const Glib::ustring & name)
+  Glib::RefPtr<Gio::SimpleAction> ActionManager::add_app_action(Glib::ustring && name)
   {
-    Glib::RefPtr<Gio::SimpleAction> action = Gio::SimpleAction::create(name);
+    auto action = Gio::SimpleAction::create(std::move(name));
     m_app_actions.push_back(action);
     return action;
   }
diff --git a/src/actionmanager.hpp b/src/actionmanager.hpp
index 7489c4cb..f5bfeabc 100644
--- a/src/actionmanager.hpp
+++ b/src/actionmanager.hpp
@@ -43,7 +43,7 @@ public:
     {
       return m_app_actions;
     }
-  Glib::RefPtr<Gio::SimpleAction> add_app_action(const Glib::ustring & name) override;
+  Glib::RefPtr<Gio::SimpleAction> add_app_action(Glib::ustring && name) override;
   void add_app_menu_item(int section, int order, Glib::ustring && label, Glib::ustring && action_def) 
override;
   void register_main_window_action(Glib::ustring && action, const Glib::VariantType *state_type, bool 
modifying = true) override;
   std::map<Glib::ustring, const Glib::VariantType*> get_main_window_actions() const override;
diff --git a/src/iactionmanager.hpp b/src/iactionmanager.hpp
index c9909ec5..d914bac1 100644
--- a/src/iactionmanager.hpp
+++ b/src/iactionmanager.hpp
@@ -34,7 +34,7 @@ public:
   virtual ~IActionManager();
 
   virtual Glib::RefPtr<Gio::SimpleAction> get_app_action(const Glib::ustring & name) const = 0;
-  virtual Glib::RefPtr<Gio::SimpleAction> add_app_action(const Glib::ustring & name) = 0;
+  virtual Glib::RefPtr<Gio::SimpleAction> add_app_action(Glib::ustring && name) = 0;
   virtual void add_app_menu_item(int section, int order, Glib::ustring && label, Glib::ustring && 
action_def) = 0;
   virtual void register_main_window_action(Glib::ustring && action, const Glib::VariantType *state_type, 
bool modifying = true) = 0;
   virtual std::map<Glib::ustring, const Glib::VariantType*> get_main_window_actions() const = 0;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]