[gnome-shell/wip/carlosg/osk-updates: 1/2] keyboard: Shuffle text direction initialization




commit 4c004bd2a48756541b1dadfb6619c1099b47f410
Author: Carlos Garnacho <carlosg gnome org>
Date:   Thu Jun 30 11:41:12 2022 +0200

    keyboard: Shuffle text direction initialization
    
    We do set the full OSK as LTR since keymaps are defined in that
    direction. Other actors inside the OSK might want differently so
    move this piece of setup to init(), so child actors can set their
    own without the OSK overwriting the value.

 js/ui/keyboard.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 3ce5ce0312..838ad40f4f 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -1289,7 +1289,15 @@ var Keyboard = GObject.registerClass({
     },
 }, class Keyboard extends St.BoxLayout {
     _init() {
-        super._init({ name: 'keyboard', reactive: true, vertical: true });
+        super._init({
+            name: 'keyboard',
+            reactive: true,
+            // Keyboard models are defined in LTR, we must override
+            // the locale setting in order to avoid flipping the
+            // keyboard on RTL locales.
+            text_direction: Clutter.TextDirection.LTR,
+            vertical: true,
+        });
         this._focusInExtendedKeys = false;
         this._emojiActive = false;
 
@@ -1414,11 +1422,6 @@ var Keyboard = GObject.registerClass({
         this._ensureKeysForGroup(this._keyboardController.getCurrentGroup());
         this._setActiveLayer(0);
 
-        // Keyboard models are defined in LTR, we must override
-        // the locale setting in order to avoid flipping the
-        // keyboard on RTL locales.
-        this.text_direction = Clutter.TextDirection.LTR;
-
         Main.inputMethod.connect(
             'terminal-mode-changed', this._onTerminalModeChanged.bind(this));
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]