[gnome-control-center] Printer panel a11y fixes



commit 2148e23d977a7a1a928fe990bbd62e14b0bab5aa
Author: Lukáš Tyrychtr <lukastyrychtr gmail com>
Date:   Mon May 16 14:07:54 2022 +0200

    Printer panel a11y fixes

 panels/printers/new-printer-dialog.ui |  8 ++++++++
 panels/printers/pp-job-row.c          | 26 ++++++++++++++++++--------
 panels/printers/pp-jobs-dialog.ui     |  3 +++
 subprojects/gvc                       |  2 +-
 4 files changed, 30 insertions(+), 9 deletions(-)
---
diff --git a/panels/printers/new-printer-dialog.ui b/panels/printers/new-printer-dialog.ui
index bd74c5620..6c24ac1ad 100644
--- a/panels/printers/new-printer-dialog.ui
+++ b/panels/printers/new-printer-dialog.ui
@@ -60,6 +60,9 @@
                 <property name="child">
                   <object class="GtkButton" id="go_back_button">
                     <property name="halign">start</property>
+                    <accessibility>
+                      <property name="label" translatable="yes">Back</property>
+                    </accessibility>
                     <child>
                       <object class="GtkImage">
                         <property name="icon-name">go-previous-symbolic</property>
@@ -245,6 +248,9 @@
                             <property name="margin_start">40</property>
                             <property name="margin_end">40</property>
                             <property name="hexpand">True</property>
+                            <accessibility>
+                              <property name="label" translatable="yes">Search</property>
+                            </accessibility>
                           </object>
                         </child>
                       </object>
@@ -309,6 +315,7 @@
                     <child>
                       <object class="GtkLabel">
                         <property name="label" translatable="yes">Username</property>
+                        <property name="mnemonic_widget">username_entry</property>
                         <layout>
                           <property name="column">0</property>
                           <property name="row">2</property>
@@ -329,6 +336,7 @@
                     <child>
                       <object class="GtkLabel">
                         <property name="label" translatable="yes">Password</property>
+                        <property name="mnemonic_widget">password_entry</property>
                         <layout>
                           <property name="column">0</property>
                           <property name="row">3</property>
diff --git a/panels/printers/pp-job-row.c b/panels/printers/pp-job-row.c
index 86b12659a..41e096f79 100644
--- a/panels/printers/pp-job-row.c
+++ b/panels/printers/pp-job-row.c
@@ -24,6 +24,9 @@
 #include "pp-job-row.h"
 #include "cc-printers-resources.h"
 
+static void
+update_pause_button (PpJobRow *self, gboolean paused);
+
 struct _PpJobRow
 {
   GtkListBoxRow parent;
@@ -45,14 +48,23 @@ enum {
 
 static guint signals[LAST_SIGNAL] = { 0 };
 
+static void
+update_pause_button (PpJobRow *self, gboolean paused) {
+  gtk_button_set_icon_name (self->pause_button,
+                            paused ? "media-playback-start-symbolic" : "media-playback-pause-symbolic");
+  gtk_accessible_update_property (GTK_ACCESSIBLE (self->pause_button),
+                                  GTK_ACCESSIBLE_PROPERTY_LABEL,
+                                  paused ? _("Resume") : _("Pause"),
+                                  -1);
+}
+
 static void
 pause_cb (PpJobRow *self)
 {
   pp_job_set_hold_until_async (self->job, pp_job_get_state (self->job) == IPP_JOB_HELD ? "no-hold" : 
"indefinite");
-  gtk_button_set_icon_name (self->pause_button,
-                            pp_job_get_state (self->job) == IPP_JOB_HELD ?
-                                              "media-playback-pause-symbolic" : 
"media-playback-start-symbolic");
-}
+  update_pause_button (self,
+                       pp_job_get_state (self->job) == IPP_JOB_HELD);
+                                              }
 
 static void
 stop_cb (PpJobRow *self)
@@ -174,9 +186,7 @@ pp_job_row_new (PpJob *job)
   if (status)
     /* Translators: Clicking this button prioritizes printing of this print job */
     gtk_widget_set_tooltip_text (GTK_WIDGET (self->priority_button), _("Move this job to the top of the 
queue"));
-  gtk_button_set_icon_name (self->pause_button,
-                            pp_job_get_state (self->job) == IPP_JOB_HELD ?
-                                              "media-playback-start-symbolic" : 
"media-playback-pause-symbolic");
-
+  update_pause_button (self,
+                       pp_job_get_state (self->job) == IPP_JOB_HELD);
   return self;
 }
diff --git a/panels/printers/pp-jobs-dialog.ui b/panels/printers/pp-jobs-dialog.ui
index e650dcf8d..530b9f77f 100644
--- a/panels/printers/pp-jobs-dialog.ui
+++ b/panels/printers/pp-jobs-dialog.ui
@@ -29,6 +29,7 @@
                 <property name="halign">start</property>
                 <property name="label" translatable="yes" comments="Translators: This is a windows domain 
used with SMB protocol.">Domain</property>
                 <property name="xalign">1</property>
+                <property name="mnemonic_widget">domain_entry</property>
                 <layout>
                   <property name="column">0</property>
                   <property name="row">0</property>
@@ -40,6 +41,7 @@
                 <property name="halign">start</property>
                 <property name="label" translatable="yes" comments="Translators: This is a username on a 
print server.">Username</property>
                 <property name="xalign">1</property>
+                <property name="mnemonic_widget">username_entry</property>
                 <layout>
                   <property name="column">0</property>
                   <property name="row">1</property>
@@ -51,6 +53,7 @@
                 <property name="halign">start</property>
                 <property name="label" translatable="yes" comments="Translators: This is a password needed 
for printing.">Password</property>
                 <property name="xalign">1</property>
+                <property name="mnemonic_widget">password_entry</property>
                 <layout>
                   <property name="column">0</property>
                   <property name="row">2</property>
diff --git a/subprojects/gvc b/subprojects/gvc
index 7a621180b..8e7a5a4c3 160000
--- a/subprojects/gvc
+++ b/subprojects/gvc
@@ -1 +1 @@
-Subproject commit 7a621180b46421e356b33972e3446775a504139c
+Subproject commit 8e7a5a4c3e51007ce6579292642517e3d3eb9c50


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]