[gnome-online-accounts/wip/rishi/foursquare-remove] Remove Foursquare

From: Debarshi Ray <debarshir src gnome org>
To: commits-list gnome org
Cc:
Subject: [gnome-online-accounts/wip/rishi/foursquare-remove] Remove Foursquare
Date: Thu, 16 Jun 2022 16:37:08 +0000 (UTC)

commit 3ab0d4668376d3f218eda9055b5566f919bb582a
Author: Debarshi Ray <debarshir gnome org>
Date:   Thu Jun 16 17:57:57 2022 +0200

    Remove Foursquare
    
    Foursquare was added for GNOME Maps.  However, GNOME Maps recently
    removed it's Foursquare support [1], so there's no use for it anymore.
    
    [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/issues/440
        https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/219
    
    https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/184

 README                                             |   6 -
 configure.ac                                       |  19 --
 data/icons/meson.build                             |   2 -
 data/icons/scalable/Makefile.am                    |   1 -
 data/icons/scalable/goa-account-foursquare.svg     | 108 ------
 data/icons/symbolic/Makefile.am                    |   1 -
 .../symbolic/goa-account-foursquare-symbolic.svg   |  31 --
 gnome-online-accounts.doap                         |   4 +-
 meson.build                                        |  14 -
 meson_options.txt                                  |   3 -
 po/POTFILES.in                                     |   1 -
 src/goabackend/Makefile.am                         |   1 -
 src/goabackend/goabackendenums.h                   |   2 +-
 src/goabackend/goafoursquareprovider.c             | 371 ---------------------
 src/goabackend/goafoursquareprovider.h             |  37 --
 src/goabackend/goaprovider.c                       |   4 -
 src/goabackend/meson.build                         |   1 -
 17 files changed, 3 insertions(+), 603 deletions(-)
---
diff --git a/README b/README
index 62e32fc1..243bcd61 100644
--- a/README
+++ b/README
@@ -27,12 +27,6 @@ Flickr
 OAuth 1.0: http://www.flickr.com/services/api/auth.oauth.html
 
 
-Foursquare
-----------
-
-OAuth 2.0: https://developer.foursquare.com/overview/auth
-
-
 Google
 ------
 
diff --git a/configure.ac b/configure.ac
index 9dc412a4..51a2d67c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -233,24 +233,6 @@ if test "$enable_flickr" != "no"; then
   AC_DEFINE(GOA_FLICKR_ENABLED, 1, [Enable Flickr data provider])
 fi
 
-# Foursquare
-AC_DEFINE(GOA_FOURSQUARE_NAME, ["foursquare"], [ProviderType and extension point name])
-AC_ARG_ENABLE([foursquare],
-              [AS_HELP_STRING([--enable-foursquare], [Enable Foursquare provider])],
-              [],
-              [enable_foursquare=yes])
-AC_ARG_WITH(foursquare-client-id,
-            [AS_HELP_STRING([--with-foursquare-client-id], [Foursquare OAuth 2.0 client id])],
-            [],
-            [])
-if test "$with_foursquare_client_id" = ""; then
-  with_foursquare_client_id="MBNU2NES5HASNDQJ25YPFGG2UGRZHPI3IYTNJGE0KIWT2HCF"
-fi
-AC_DEFINE_UNQUOTED(GOA_FOURSQUARE_CLIENT_ID, ["$with_foursquare_client_id"], [Foursquare OAuth 2.0 client 
id])
-if test "$enable_foursquare" != "no"; then
-  AC_DEFINE(GOA_FOURSQUARE_ENABLED, 1, [Enable Foursquare data provider])
-fi
-
 # Google
 AC_DEFINE(GOA_GOOGLE_NAME, ["google"], [ProviderType and extension point name])
 AC_ARG_ENABLE([google],
@@ -567,7 +549,6 @@ echo "
 
        Fedora Account System provider: ${enable_fedora}
        Flickr provider:                ${enable_flickr} (OAuth 1.0, key:${with_flickr_consumer_key} 
secret:${with_flickr_consumer_secret})
-       Foursquare provider:            ${enable_foursquare} (id:${with_foursquare_client_id})
        Google provider:                ${enable_google} (OAuth 2.0, id:${with_google_client_id} 
secret:${with_google_client_secret})
        IMAP/SMTP provider:             ${enable_imap_smtp}
        Media Server provider:          ${enable_media_server}
diff --git a/data/icons/meson.build b/data/icons/meson.build
index 281c5388..ce76e852 100644
--- a/data/icons/meson.build
+++ b/data/icons/meson.build
@@ -4,7 +4,6 @@ icon_scalable_data = [
   'goa-account-facebook.svg',
   'goa-account-fedora.svg',
   'goa-account-flickr.svg',
-  'goa-account-foursquare.svg',
   'goa-account-google.svg',
   'goa-account-lastfm.svg',
   'goa-account-msn.svg',
@@ -16,7 +15,6 @@ icon_symbolic_data = [
   'goa-account-exchange-symbolic.svg',
   'goa-account-facebook-symbolic.svg',
   'goa-account-flickr-symbolic.svg',
-  'goa-account-foursquare-symbolic.svg',
   'goa-account-google-symbolic.svg',
   'goa-account-lastfm-symbolic.svg',
   'goa-account-msn-symbolic.svg',
diff --git a/data/icons/scalable/Makefile.am b/data/icons/scalable/Makefile.am
index 5721dd55..bfca08ed 100644
--- a/data/icons/scalable/Makefile.am
+++ b/data/icons/scalable/Makefile.am
@@ -11,7 +11,6 @@ icon_DATA =                           \
        goa-account-lastfm.svg          \
        goa-account-msn.svg             \
        goa-account-owncloud.svg        \
-       goa-account-foursquare.svg      \
        $(NULL)
 
 EXTRA_DIST = \
diff --git a/data/icons/symbolic/Makefile.am b/data/icons/symbolic/Makefile.am
index 1ba8100b..abc00f63 100644
--- a/data/icons/symbolic/Makefile.am
+++ b/data/icons/symbolic/Makefile.am
@@ -10,7 +10,6 @@ icon_DATA =                                   \
        goa-account-lastfm-symbolic.svg         \
        goa-account-msn-symbolic.svg            \
        goa-account-owncloud-symbolic.svg       \
-       goa-account-foursquare-symbolic.svg     \
        $(NULL)
 
 EXTRA_DIST = \
diff --git a/gnome-online-accounts.doap b/gnome-online-accounts.doap
index b8d4e7c9..38321dfc 100644
--- a/gnome-online-accounts.doap
+++ b/gnome-online-accounts.doap
@@ -12,8 +12,8 @@
   <description xml:lang="en">
 GNOME Online Accounts provides interfaces so that applications and libraries
 in GNOME can access the user's online accounts. It has providers for Google,
-Nextcloud, Facebook, Fedora, Microsoft, Flickr, Foursquare, Microsoft
-Exchange, Last.fm, IMAP/SMTP and Kerberos.
+Nextcloud, Facebook, Fedora, Microsoft, Flickr, Microsoft Exchange, Last.fm,
+IMAP/SMTP and Kerberos.
   </description>
 
   <homepage rdf:resource="https://wiki.gnome.org/Projects/GnomeOnlineAccounts"; />
diff --git a/meson.build b/meson.build
index cd3fffec..788ff2f0 100644
--- a/meson.build
+++ b/meson.build
@@ -154,15 +154,6 @@ config_h.set_quoted('GOA_FLICKR_CONSUMER_SECRET', flickr_consumer_secret)
 enable_flickr = get_option('flickr')
 config_h.set('GOA_FLICKR_ENABLED', enable_flickr)
 
-# Foursquare
-config_h.set_quoted('GOA_FOURSQUARE_NAME', 'foursquare')
-
-foursquare_client_id = get_option('foursquare_client_id')
-config_h.set_quoted('GOA_FOURSQUARE_CLIENT_ID', foursquare_client_id)
-
-enable_foursquare = get_option('foursquare')
-config_h.set('GOA_FOURSQUARE_ENABLED', enable_foursquare)
-
 # Google
 config_h.set_quoted('GOA_GOOGLE_NAME', 'google')
 
@@ -319,11 +310,6 @@ if enable_flickr
   output += ' (OAuth 1.0, key:@0@)'.format(flickr_consumer_key)
 endif
 output += '\n'
-output += '        Foursquare provider:            ' + enable_foursquare.to_string()
-if enable_foursquare
-  output += ' (id:@0@)'.format(foursquare_client_id)
-endif
-output += '\n'
 output += '        Google provider:                ' + enable_google.to_string()
 if enable_google
   output += ' (OAuth 2.0, id:@0@ secret:@1@)'.format(google_client_id, google_client_secret)
diff --git a/meson_options.txt b/meson_options.txt
index 08c65ecd..c2765943 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -12,9 +12,6 @@ option('flickr', type: 'boolean', value: true, description: 'Enable Flickr provi
 option('flickr_consumer_key', type: 'string', value: 'ed00ad7e0869897506e23c0d18e34d01', description: 
'Flickr OAuth 1.0 consumer key')
 option('flickr_consumer_secret', type: 'string', value: 'ebd556dd187188b1', description: 'Flickr OAuth 1.0 
consumer secret')
 
-option('foursquare', type: 'boolean', value: true, description: 'Enable Foursquare provider')
-option('foursquare_client_id', type: 'string', value: 'MBNU2NES5HASNDQJ25YPFGG2UGRZHPI3IYTNJGE0KIWT2HCF', 
description: 'Foursquare OAuth 2.0 client id')
-
 option('google', type: 'boolean', value: true, description: 'Enable Google provider')
 option('google_client_id', type: 'string', value: 
'44438659992-7kgjeitenc16ssihbtdjbgguch7ju55s.apps.googleusercontent.com', description: 'Google OAuth 2.0 
client id')
 option('google_client_secret', type: 'string', value: '-gMLuQyDiI0XrQS_vx_mhuYF', description: 'Google OAuth 
2.0 client secret')
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 279fb64d..aee26ab8 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -7,7 +7,6 @@ src/goabackend/goaexchangeprovider.c
 src/goabackend/goafacebookprovider.c
 src/goabackend/goafedoraprovider.c
 src/goabackend/goaflickrprovider.c
-src/goabackend/goafoursquareprovider.c
 src/goabackend/goagoogleprovider.c
 src/goabackend/goaimapauthlogin.c
 src/goabackend/goaimapsmtpprovider.c
diff --git a/src/goabackend/Makefile.am b/src/goabackend/Makefile.am
index 83852378..105ea2c7 100644
--- a/src/goabackend/Makefile.am
+++ b/src/goabackend/Makefile.am
@@ -90,7 +90,6 @@ libgoa_backend_1_0_la_SOURCES =                                               \
        goamediaserverprovider.h        goamediaserverprovider.c        \
        goaowncloudprovider.h           goaowncloudprovider.c           \
        goaflickrprovider.h             goaflickrprovider.c             \
-       goafoursquareprovider.h         goafoursquareprovider.c         \
        goawindowsliveprovider.h        goawindowsliveprovider.c        \
        goalastfmprovider.h             goalastfmprovider.c             \
        goaobjectskeletonutils.h        goaobjectskeletonutils.c        \
diff --git a/src/goabackend/goabackendenums.h b/src/goabackend/goabackendenums.h
index cba20e28..69574759 100644
--- a/src/goabackend/goabackendenums.h
+++ b/src/goabackend/goabackendenums.h
@@ -69,7 +69,7 @@ typedef enum
  * @GOA_PROVIDER_FEATURE_TICKETING: Ticketing services (ie. Kerberos).
  * @GOA_PROVIDER_FEATURE_READ_LATER: Deprecated; currently unused.
  * @GOA_PROVIDER_FEATURE_PRINTERS: Network printing services (e.g. Google Cloud Print).
- * @GOA_PROVIDER_FEATURE_MAPS: Maps related services (e.g. Foursquare, Facebook).
+ * @GOA_PROVIDER_FEATURE_MAPS: Maps related services (e.g. Facebook).
  * @GOA_PROVIDER_FEATURE_MUSIC: Music related services (e.g. Vkontakte).
  * @GOA_PROVIDER_FEATURE_TODO: Deprecated; currently unused.
  * @GOA_PROVIDER_FEATURE_INVALID: Used for error handling. No provider
diff --git a/src/goabackend/goaprovider.c b/src/goabackend/goaprovider.c
index 9e5bd45a..8055957b 100644
--- a/src/goabackend/goaprovider.c
+++ b/src/goabackend/goaprovider.c
@@ -28,7 +28,6 @@
 #include "goaimapsmtpprovider.h"
 #include "goaowncloudprovider.h"
 #include "goaflickrprovider.h"
-#include "goafoursquareprovider.h"
 #include "goawindowsliveprovider.h"
 #include "goamediaserverprovider.h"
 #include "goalastfmprovider.h"
@@ -950,9 +949,6 @@ static struct
 #ifdef GOA_FLICKR_ENABLED
   { GOA_FLICKR_NAME, goa_flickr_provider_get_type },
 #endif
-#ifdef GOA_FOURSQUARE_ENABLED
-  { GOA_FOURSQUARE_NAME, goa_foursquare_provider_get_type },
-#endif
 #ifdef GOA_EXCHANGE_ENABLED
   { GOA_EXCHANGE_NAME, goa_exchange_provider_get_type },
 #endif
diff --git a/src/goabackend/meson.build b/src/goabackend/meson.build
index 3d9dee8b..8244fade 100644
--- a/src/goabackend/meson.build
+++ b/src/goabackend/meson.build
@@ -10,7 +10,6 @@ libgoa_backend_sources = files(
   'goaexchangeprovider.c',
   'goafacebookprovider.c',
   'goaflickrprovider.c',
-  'goafoursquareprovider.c',
   'goagoogleprovider.c',
   'goahttpclient.c',
   'goaimapauthlogin.c',
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]