[epiphany/mcatanzaro/#736] gsb-service: ref self for lifetime of update thread



commit 6600b451d5bf06d94145edda733aaf6bdf5ee92e
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Thu Apr 18 15:05:21 2019 -0500

    gsb-service: ref self for lifetime of update thread
    
    Fixes #736

 lib/safe-browsing/ephy-gsb-service.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/lib/safe-browsing/ephy-gsb-service.c b/lib/safe-browsing/ephy-gsb-service.c
index fd9d84d54..d31fbc154 100644
--- a/lib/safe-browsing/ephy-gsb-service.c
+++ b/lib/safe-browsing/ephy-gsb-service.c
@@ -292,6 +292,8 @@ out:
   g_list_free_full (threat_lists, (GDestroyNotify)ephy_gsb_threat_list_free);
 
   ephy_gsb_storage_set_metadata (self->storage, "next_list_updates_time", self->next_list_updates_time);
+
+  g_object_unref (self);
 }
 
 static void
@@ -313,7 +315,7 @@ ephy_gsb_service_update (EphyGSBService *self)
   g_assert (ephy_gsb_storage_is_operable (self->storage));
 
   g_atomic_int_set (&self->is_updating, TRUE);
-  task = g_task_new (self, NULL,
+  task = g_task_new (g_object_ref (self), NULL,
                      (GAsyncReadyCallback)ephy_gsb_service_update_finished_cb,
                      NULL);
   g_task_run_in_thread (task, (GTaskThreadFunc)ephy_gsb_service_update_thread);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]