[gimp] Bug 787321 - Editing shear tool values numerically can have no effect



commit 699b835c87554c3d74cc84a1e4f59bfaa88561fa
Author: Richard McLean <programmer_ceds yahoo co uk>
Date:   Tue Sep 5 18:49:24 2017 +0100

    Bug 787321 - Editing shear tool values numerically can have no effect
    
    If the user enters a value in the shear tool dialog, that value must
    be honored. Always set the shear direction to the edited axis and
    reset the other axis to 0.

 app/tools/gimpsheartool.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/app/tools/gimpsheartool.c b/app/tools/gimpsheartool.c
index 8eccaaa..8ad5cb8 100644
--- a/app/tools/gimpsheartool.c
+++ b/app/tools/gimpsheartool.c
@@ -287,10 +287,10 @@ shear_x_mag_changed (GtkAdjustment     *adj,
 
   if (value != tr_tool->trans_info[SHEAR_X])
     {
-      if (tr_tool->trans_info[ORIENTATION] == GIMP_ORIENTATION_UNKNOWN)
-        tr_tool->trans_info[ORIENTATION] = GIMP_ORIENTATION_HORIZONTAL;
+      tr_tool->trans_info[ORIENTATION] = GIMP_ORIENTATION_HORIZONTAL;
 
       tr_tool->trans_info[SHEAR_X] = value;
+      tr_tool->trans_info[SHEAR_Y] = 0.0;  /* can only shear in one axis */
 
       gimp_transform_tool_push_internal_undo (tr_tool);
 
@@ -306,10 +306,10 @@ shear_y_mag_changed (GtkAdjustment     *adj,
 
   if (value != tr_tool->trans_info[SHEAR_Y])
     {
-      if (tr_tool->trans_info[ORIENTATION] == GIMP_ORIENTATION_UNKNOWN)
-        tr_tool->trans_info[ORIENTATION] = GIMP_ORIENTATION_VERTICAL;
+      tr_tool->trans_info[ORIENTATION] = GIMP_ORIENTATION_VERTICAL;
 
       tr_tool->trans_info[SHEAR_Y] = value;
+      tr_tool->trans_info[SHEAR_X] = 0.0;  /* can only shear in one axis */
 
       gimp_transform_tool_push_internal_undo (tr_tool);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]