[evince] view: Fix infinite loop over annotation windows
- From: Carlos Garcia Campos <carlosgc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evince] view: Fix infinite loop over annotation windows
- Date: Sat, 19 Aug 2017 06:39:12 +0000 (UTC)
commit 6ced48f813144794431e5a2e563dc880558f9ab9
Author: Jose Aliste <jaliste src gnome org>
Date: Tue Aug 8 20:48:00 2017 -0500
view: Fix infinite loop over annotation windows
When fixing bug 760299, we introduced an infinite loop
that is triggered (sometimes) when removing annotations.
This patch fixes that.
https://bugzilla.gnome.org/show_bug.cgi?id=785975
libview/ev-view.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/libview/ev-view.c b/libview/ev-view.c
index 6f96276..197cd3d 100644
--- a/libview/ev-view.c
+++ b/libview/ev-view.c
@@ -3017,9 +3017,10 @@ ev_view_remove_window_child_for_annot (EvView *view,
child = (EvViewWindowChild *)children->data;
- if (child->page != page)
+ if (child->page != page) {
+ children = children->next;
continue;
-
+ }
wannot = ev_annotation_window_get_annotation (EV_ANNOTATION_WINDOW (child->window));
if (ev_annotation_equal (wannot, annot)) {
gtk_widget_destroy (child->window);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]