[gnome-software] trivial: Never use remote icons for shell extensions

[Richard Hughes <rhughes src gnome org>]

commit 4acc80392427d55bcc338cf9f7222e44fe8fb2fa
Author: Richard Hughes <richard hughsie com>
Date:   Sun Jun 12 09:04:39 2016 +0100

    trivial: Never use remote icons for shell extensions
    
    The remote icons are sometimes missing, or of poor quality and are usually very
    low resolution.

 src/plugins/gs-plugin-shell-extensions.c |   15 ++++-----------
 1 files changed, 4 insertions(+), 11 deletions(-)
---
diff --git a/src/plugins/gs-plugin-shell-extensions.c b/src/plugins/gs-plugin-shell-extensions.c
index 35b3f0c..e9ad16d 100644
--- a/src/plugins/gs-plugin-shell-extensions.c
+++ b/src/plugins/gs-plugin-shell-extensions.c
@@ -430,19 +430,12 @@ gs_plugin_shell_extensions_parse_app (GsPlugin *plugin,
        }
        tmp = json_object_get_string_member (json_app, "icon");
        if (tmp != NULL) {
-               g_autofree gchar *uri = NULL;
                g_autoptr(AsIcon) ic = NULL;
-
-               /* use stock icon for generic */
+               /* just use a stock icon as the remote icons are
+                * sometimes missing, poor quality and low resolution */
                ic = as_icon_new ();
-               if (g_strcmp0 (tmp, "/static/images/plugin.png") == 0) {
-                       as_icon_set_kind (ic, AS_ICON_KIND_STOCK);
-                       as_icon_set_name (ic, "application-x-addon-symbolic");
-               } else {
-                       uri = g_build_filename (SHELL_EXTENSIONS_API_URI, tmp, NULL);
-                       as_icon_set_kind (ic, AS_ICON_KIND_REMOTE);
-                       as_icon_set_url (ic, uri);
-               }
+               as_icon_set_kind (ic, AS_ICON_KIND_STOCK);
+               as_icon_set_name (ic, "application-x-addon-symbolic");
                as_app_add_icon (app, ic);
        }