[smuxi: 2/4] Frontend: fixed Trace.Call() calls in ChatViewSyncManager



commit 1495be27eece4456ef4e340228b169bd2e199e34
Author: Mirco Bauer <meebey meebey net>
Date:   Tue Aug 26 11:21:39 2014 +0200

    Frontend: fixed Trace.Call() calls in ChatViewSyncManager
    
    Trace.Call() can't be tricked to log parameters that are not part of the
    method's signature. If extra information is needed then the logger needs to be
    used instead.

 src/Frontend/ChatViewSyncManager.cs |   23 ++++++++++++-----------
 1 files changed, 12 insertions(+), 11 deletions(-)
---
diff --git a/src/Frontend/ChatViewSyncManager.cs b/src/Frontend/ChatViewSyncManager.cs
index 40a5a6b..f211893 100644
--- a/src/Frontend/ChatViewSyncManager.cs
+++ b/src/Frontend/ChatViewSyncManager.cs
@@ -127,7 +127,7 @@ namespace Smuxi.Frontend
 
             public override void ExecuteAdd()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new AddedState(SyncInfo);
             }
         }
@@ -171,19 +171,19 @@ namespace Smuxi.Frontend
 
             public override void ExecuteReadyToSync()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new WaitingForSyncState(SyncInfo);
             }
 
             public override void ExecuteSync()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new SyncQueuedState(SyncInfo);
             }
 
             public override void ExecuteRemove()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new RemovingState(SyncInfo);
             }
         }
@@ -196,7 +196,7 @@ namespace Smuxi.Frontend
 
             public override void ExecuteReadyToSync()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new SyncingState(SyncInfo);
             }
         }
@@ -209,13 +209,13 @@ namespace Smuxi.Frontend
 
             public override void ExecuteSync()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new SyncingState(SyncInfo);
             }
 
             public override void ExecuteRemove()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new RemovingState(SyncInfo);
             }
         }
@@ -243,7 +243,7 @@ namespace Smuxi.Frontend
 
             public override void ExecuteSyncFinished()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new SyncState(SyncInfo);
             }
         }
@@ -256,14 +256,14 @@ namespace Smuxi.Frontend
 
             public override void ExecuteRemove()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new RemovingState(SyncInfo);
             }
 
             public override void ExecuteSync()
             {
                 // this happens for example in /rejoin
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.State = new SyncingState(SyncInfo);
             }
         }
@@ -281,12 +281,13 @@ namespace Smuxi.Frontend
 
             public override void ExecuteRemoveFinished()
             {
-                Trace.Call(SyncInfo.ChatModel);
+                Trace.Call();
                 SyncInfo.Manager.Remove(SyncInfo.ChatModel);
             }
 
             public override void ExecuteReadyToSync()
             {
+                Trace.Call();
                 // no-op
                 // this can happen when you add and remove very fast after each other.
                 // the add callback might be in a different thread and therefore be delayed


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]