[glibmm/gmmproc-refactor] Add a bunch of TODOs.



commit 1b5bff7733e1b436df806975e2f58b3c9af31c60
Author: Krzesimir Nowak <qdlacz gmail com>
Date:   Wed Jun 6 04:12:49 2012 +0200

    Add a bunch of TODOs.

 tools/pm/Common/Gmmproc.pm        |    2 ++
 tools/pm/Common/SectionManager.pm |    4 ++++
 2 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/tools/pm/Common/Gmmproc.pm b/tools/pm/Common/Gmmproc.pm
index c8dabfb..556852a 100644
--- a/tools/pm/Common/Gmmproc.pm
+++ b/tools/pm/Common/Gmmproc.pm
@@ -83,6 +83,7 @@ sub _read_all_bases ($)
 
     unless (defined $fd)
     {
+# TODO: do proper logging.
       print 'Could not open file `' . $hg . '\' for reading.' . "\n";
       exit 1;
     }
@@ -265,6 +266,7 @@ sub add_base ($$)
 
   if (exists $bases->{$base})
   {
+# TODO: is proper logging needed at this stage?
     print STDERR 'Base `' . $base . ' was already added.' . "\n";
     return;
   }
diff --git a/tools/pm/Common/SectionManager.pm b/tools/pm/Common/SectionManager.pm
index 82271e5..93dbdcc 100644
--- a/tools/pm/Common/SectionManager.pm
+++ b/tools/pm/Common/SectionManager.pm
@@ -247,6 +247,7 @@ sub _append_stuff_to_entries ($$$$$)
     }
     default
     {
+# TODO: do proper logging.
       print STDERR 'Wrong type of entry.' . "\n";
       exit 1;
     }
@@ -459,6 +460,7 @@ sub write_main_section_to_file ($$$)
 
   unless (exists $main_sections->{$section_name})
   {
+# TODO: do proper logging.
     print STDERR 'No such main section: `' . $section_name . '\'.' . "\n";
     exit 1;
   }
@@ -471,6 +473,7 @@ sub write_main_section_to_file ($$$)
 
   unless (defined $fd)
   {
+# TODO: do proper logging.
     print STDERR 'Could not open file `' . $file_name . '\' for writing.' . "\n";
     exit 1;
   }
@@ -513,6 +516,7 @@ sub write_main_section_to_file ($$$)
       }
       default
       {
+# TODO: do proper logging.
         print STDERR 'Unknown type of entry in section.' . "\n";
         exit 1;
       }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]