[pitivi: 50/65] Renamed the PresetManager.changed method so the name starts with a verb



commit 51a775578f015ccede1d232a21f8362869c46c7f
Author: Alex BÄluÈ <alexandru balut gmail com>
Date:   Thu Jun 16 20:50:48 2011 +0200

    Renamed the PresetManager.changed method so the name starts with a verb

 pitivi/ui/preset.py          |    9 +++++----
 pitivi/ui/projectsettings.py |    8 ++++----
 2 files changed, 9 insertions(+), 8 deletions(-)
---
diff --git a/pitivi/ui/preset.py b/pitivi/ui/preset.py
index b631436..f6f088a 100644
--- a/pitivi/ui/preset.py
+++ b/pitivi/ui/preset.py
@@ -168,13 +168,14 @@ class PresetManager(object):
         for field, (setter, getter) in self.widget_map.iteritems():
             values[field] = getter()
 
-    def changed(self):
+    def isCurrentPresetChanged(self):
+        """Return whether the widgets values differ from those of the preset."""
         if not self.cur_preset:
+            # There is no preset selected, nothing to do.
             return False
-
         values = self.presets[self.cur_preset]
-        return any((values[field] != getter() for field, (setter, getter)
-            in self.widget_map.iteritems()))
+        return any((values[field] != getter()
+                    for field, (setter, getter) in self.widget_map.iteritems()))
 
 
 class VideoPresetManager(PresetManager):
diff --git a/pitivi/ui/projectsettings.py b/pitivi/ui/projectsettings.py
index c91705b..831cd69 100644
--- a/pitivi/ui/projectsettings.py
+++ b/pitivi/ui/projectsettings.py
@@ -410,22 +410,22 @@ class ProjectSettingsDialog():
         self.save_video_preset_button.set_sensitive(False)
 
     def _updateAudioPresetButtons(self):
-        preset_changed = self.audio_presets.changed()
+        preset_changed = self.audio_presets.isCurrentPresetChanged()
         self.save_audio_preset_button.set_sensitive(preset_changed)
         preset_selected = bool(self.audio_presets.cur_preset)
         self.remove_audio_preset_button.set_sensitive(preset_selected)
 
     def _updateVideoPresetButtons(self):
-        preset_changed = self.video_presets.changed()
+        preset_changed = self.video_presets.isCurrentPresetChanged()
         self.save_video_preset_button.set_sensitive(preset_changed)
         preset_selected = bool(self.video_presets.cur_preset)
         self.remove_video_preset_button.set_sensitive(preset_selected)
     
     def _updateAudioSaveButton(self, unused_in, button):
-        button.set_sensitive(self.audio_presets.changed())
+        button.set_sensitive(self.audio_presets.isCurrentPresetChanged())
 
     def _updateVideoSaveButton(self, unused_in, button):
-        button.set_sensitive(self.video_presets.changed())
+        button.set_sensitive(self.video_presets.isCurrentPresetChanged())
 
     def darSelected(self):
         return self.select_dar_radiobutton.props.active



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]