[goffice] win32: fix setting of configuration bools.



commit b886ed1c94d95d983824201a852fadcfdf497f77
Author: Morten Welinder <terra gnome org>
Date:   Tue May 4 22:22:48 2010 -0400

    win32: fix setting of configuration bools.

 ChangeLog                   |   13 ++++++++++---
 NEWS                        |    1 +
 goffice/app/go-conf-win32.c |    4 +++-
 3 files changed, 14 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 6597160..17fe7e8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,17 +1,24 @@
+2010-05-04  Morten Welinder  <terra gnome org>
+
+	* goffice/app/go-conf-win32.c (go_conf_win32_get): Restore last
+	backslash for error messages.
+	(go_conf_set_bool): Set the right value.  Fixes #617672.
+
 2010-05-03  Morten Welinder  <terra gnome org>
 
 	* goffice/math/go-regression.c (LUPDecomp): Handle nan entries.
 
 2010-05-01  Jean Brefort  <jean brefort normalesup org>
 
-	* goffice/canvas/goc-graph.c (goc_graph_do_tooltip): use markup for tips.
+	* goffice/canvas/goc-graph.c (goc_graph_do_tooltip): use markup
+	for tips.
 
 2010-04-27  Jean Brefort  <jean brefort normalesup org>
 
 	* configure.in: check for gtk_widget_send_focus_change().
 	* goffice/gtk/go-action-combo-color.c (cb_color_changed),
-	(go_action_combo_color_class_init): implement the "combo-activate" signal.
-	[#583175]
+	(go_action_combo_color_class_init): implement the "combo-activate"
+	signal.	[#583175]
 	* goffice/gtk/go-action-combo-pixmaps.c (cb_selection_changed),
 	(go_action_combo_pixmaps_class_init): ditto.
 	* goffice/gtk/go-combo-box.c (do_focus_change): use
diff --git a/NEWS b/NEWS
index db104a9..29bf084 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ Jean:
 Morten:
 	* Fix week numbers issue.
 	* Fix matrix inversion crash.  [Part of #617469]
+	* Fix win32 configuration problem.  [#617672]
 
 --------------------------------------------------------------------------
 goffice 0.8.2:
diff --git a/goffice/app/go-conf-win32.c b/goffice/app/go-conf-win32.c
index 39e819f..3d504f8 100644
--- a/goffice/app/go-conf-win32.c
+++ b/goffice/app/go-conf-win32.c
@@ -138,6 +138,8 @@ go_conf_win32_get (GOConfNode *node, gchar const *key,
 	RegCloseKey (hKey);
 
 out:
+	*last_sep = '\\';
+
 	if (ret != ERROR_SUCCESS && complain) {
 		LPTSTR msg_buf;
 
@@ -263,7 +265,7 @@ go_conf_free_node (GOConfNode *node)
 void
 go_conf_set_bool (GOConfNode *node, gchar const *key, gboolean val_)
 {
-	guchar val = val ? 1 : 0;
+	guchar val = val_ ? 1 : 0;
 
 	go_conf_win32_set (node, key, REG_BINARY, &val, sizeof (val));
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]