Re: [PATCH 3/4] SFIDL: fix compiled-in standard include path



Hey Stefan,

thanks for the patch.
Unfortunately it clashes with some local modifications I have here for versioning, so I'll probably have to 
fix this manually and have a question.

On 18.10.2015 16:42, Stefan Westerfeld wrote:
diff --git a/sfi/sfidl-options.cc b/sfi/sfidl-options.cc
index 1347481..bcdeb18 100644
--- a/sfi/sfidl-options.cc
+++ b/sfi/sfidl-options.cc
@@ -168,7 +168,7 @@ bool Options::parse (int *argc_p, char **argv_p[], const Parser& parser)
   /* add std include path */
   if (!noStdInc)
     {
-      const std::string stdinc_path = bse_installpath (BSE_INSTALLPATH_INCLUDES);
+      const std::string stdinc_path = bse_installpath (BSE_INSTALLPATH_PKGINCLUDEDIR);

Please remind me what sfild needs/uses the standard include path for.
Afaics, your BSE_INSTALLPATH_PKGINCLUDEDIR points to the directory that contains public BSE C++ headers, 
how's that helping the IDL compiler?

Given that sfidl is on its way to deprecation, I'd like to keep changes regarding it to a minimum.

-- 
Yours sincerely,
Tim Janik

https://testbit.eu/timj/
Free software author and speaker.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]