Re: got an exception

[Alexander Larsson <alexl redhat com>]

On Fri, 2005-05-06 at 13:29 +0200, Alexander Larsson wrote:
> When working on something else i noticed i got this in the server:
> 
> Exception in thread "Yarrr client Reaper" java.lang.NullPointerException
>         at org.gnome.yarrr.HibernateUtil.addChangedObject(HibernateUtil.java:163)
>         at org.gnome.yarrr.Monitor.queueSignalChanged(Monitor.java:56)
>         at org.gnome.yarrr.ReferencableObject.signalChanged(ReferencableObject.java:70)
>         at org.gnome.yarrr.ToplevelReferencableObject.clientInactive(ToplevelReferencableObject.java:124)
>         at org.gnome.yarrr.ClientPoll.detectedInactive(ClientPoll.java:140)
>         at org.gnome.yarrr.Yarrr$ClientReaper.reap(Yarrr.java:323)
>         at org.gnome.yarrr.Yarrr$ClientReaper.run(Yarrr.java:334)
> 
> Maybe we broke reaping of inactive clients? 
> 
> I'll look at it in a while unless someone else gets to it first.

Ah, this is due to the change to queue signal notifications in a
thread-local variable and emit them at transaction commit time. However,
the reaper thread has no such thread-local variable.

Maybe its better to revert this and solve the notification problems by
commiting at the right times instead? I mean, the reaper thread could do
some hibernate magic, but it seems like enforcing a hibernate session
and an xmlrc call just to emit a signal event is a bit unnecessary and
causes unneeded complexity.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a maverick one-eyed master criminal with a winning smile and a way with 
the ladies. She's a cosmopolitan belly-dancing museum curator on her way to 
prison for a murder she didn't commit. They fight crime!