[xslt] Various "make distcheck" and other fixes remove a line in configure EXTRA_LIBS=... LIBXML_LIBS...



Hi Daniel,

The patch remove a line
 -EXTRA_LIBS="$EXTRA_LIBS $LIBXML_LIBS $M_LIBS"

This is not save as libxslt/Makefile.am define only
|EXTRA_LIBS|  as dependency:
|libxslt_la_LIBADD= $(EXTRA_LIBS)|

If platform does not support unresolved dependencies library cannot be linked.
Even with support regression tests fail in python test due unresolved "xml"-symbols .

May be line has to be restored but with different order - EXTRA_LIBS="$LIBXML_LIBS $M_LIBS $EXTRA_LIBS".

Now I use 0001-fix-regresson-in-Various-make-distcheck-and-other-fi.patch to build libxslt against current libxml source build (--with-libxml-src....)

Roumen

>From 758a75416f1692ade1cb93ad8d16c3a5ac07f6ff Mon Sep 17 00:00:00 2001
From: Roumen Petrov <bugtrack roumenpetrov info>
Date: Fri, 10 Aug 2012 01:22:02 +0300
Subject: [PATCH] fix regresson in Various "make distcheck" and other fixes

---
 libxslt/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libxslt/Makefile.am b/libxslt/Makefile.am
index 8930de3..d4619d2 100644
--- a/libxslt/Makefile.am
+++ b/libxslt/Makefile.am
@@ -60,7 +60,7 @@ else
 LIBXSLT_VERSION_SCRIPT =
 endif
 
-libxslt_la_LIBADD = $(EXTRA_LIBS)
+libxslt_la_LIBADD = $(LIBXML_LIBS) $(EXTRA_LIBS)
 libxslt_la_LDFLAGS =					\
 		$(WIN32_EXTRA_LDFLAGS)			\
 		$(LIBXSLT_VERSION_SCRIPT)		\
-- 
1.7.4.4



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]