Re: [xslt] Patch for xsl:sort lang support

On Tue, Jun 03, 2008 at 08:09:38PM +0200, Nick Wellnhofer wrote:
> Daniel Veillard wrote:
> >On Thu, May 15, 2008 at 02:46:17PM +0200, Nick Wellnhofer wrote:
> >  Okay, thanks !
> >I finally took the time to apply your patch (no I hadn't forgotten :-)
> >it's now in SVN !
> >Just one thing, it would be nice to add a couple of simple example
> >to test taht this is working correctly in the regression tests, if you
> >have some that would be a good addition.
> Yes, I had a test case in the first patch I sent. But you need to have 
> the required locales installed with locale-gen on some systems, 
> otherwise the tests won't work. I don't know if this is a problem.

Maybe something as dumb as just checking an ISO Latin 1 sort would
work pretty much everywhere, that's my guess.

> Another thing I'm not sure about is the configure check. Maybe it would 
> be better to use AC_TRY_COMPILE instead of AC_TRY_RUN here?

  Hum, AC_TRY_COMPILE would just check that we can find the headers and
link in newlocale and strxfrm_l . Maybe that's sufficient on the compile
box, the locale test may fail on the server compile farm but work on the
target box for example. I mot 100% sure though...
  Oh and i forgot to commit the 2 new files ... done, now !


Red Hat Virtualization group
Daniel Veillard      | virtualization library
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]