Re: [xslt] FYI on string interning of XSLT transform mode/modeURI

[Daniel Veillard <veillard redhat com>]

On Tue, Mar 22, 2005 at 03:05:17PM -0800, Mark Vakoc wrote:
> >    This is a good idea, but where, maybe in xsltApplyStylesheetInternal() ?
> > Another possibility would be to force the interning at that level instead of
> > generating an error, but I really didn't expect people would tweak those
> > data .
> 
> I didn't look to see where else this may apply, I assummed other items were
> likely interned.  Maybe it isn't much of an issue but could be a good idea
> since the fallback xmlStrEqual calls are no longer there at least in this case.

  Okay I added interning of mode and modeURI in xsltApplyStylesheetInternal().
I didn't found any other string in the transform context which may lead to
similar problem. Finger crosssed ...

> 
> I've always been worried that my xslt extensions would someday run into trouble
> with hte dictionary, though most of them now do use the transform context's
> dictionary to try to minimize memory used (most of the xslt extensions retrieve
> external data).

  the whole dictionnary thing has been an exercise in refining an existing
API carving stuff underneath while trying very very hard to not break any
application, risky business for sure :-\

> BTW I changing the mode flag was a way around XSLT's in my opinion limitation
> on not being able to use attribute value templates for the mode when applying
> templates.

  Well, that's XSLT, if I change it I will get another kind of bug report :-\
Anyway I hope the next version will work for you.

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/