[xslt] Do not free the hash keys during xmlHashScanFull



One of our developers applied the appended patch; his comment goes as
follows:

    Do not free the hash keys during xmlHashScanFull, it will corrupt
    the hash table. The keys will be freed by xmlHashFree right
    afterwards anyway. #30506

If wanted I can provide a qualified account for accessing the suse
bugzilla system.

We free the entries in the function below already.

Freeing the hash keys in xmlHashFullScan will not work, since the
iter->next pointer does not stay constant.

--- libxslt-1.0.32/libxslt/extensions.c.fix	2003-09-18 17:38:58.000000000 +0200
+++ libxslt-1.0.32/libxslt/extensions.c	2003-09-18 17:39:00.000000000 +0200
@@ -701,8 +701,6 @@
                      "Shutting down module : %s\n", URI);
 #endif
     module->shutdownFunc(ctxt, URI, data->extData);
-    xmlHashRemoveEntry(ctxt->extInfos, URI,
-                       (xmlHashDeallocator) xsltFreeExtData);
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]