Re: [xslt] build system is not idempotent

[Graham Wilson <bob decoy wox org>]

On Tue, Sep 16, 2003 at 03:30:38PM -0400, Daniel Veillard wrote:
> On Tue, Sep 16, 2003 at 02:19:59PM -0500, Graham Wilson wrote:
[bugs about files not being cleaned properly]
> 
>   Okay 1-3 are small bugs, I take patch (libxml2 probably suffers the
> same problems).

i can file the patch below with bugzilla if you want.

Index: python/Makefile.am
===================================================================
--- python/Makefile.am	(revision 21)
+++ python/Makefile.am	(working copy)
@@ -53,7 +53,8 @@
 GENERATED= $(srcdir)/libxsltclass.py \
            $(srcdir)/libxslt-export.c \
 	   $(srcdir)/libxslt-py.c \
-	   $(srcdir)/libxslt-py.h
+	   $(srcdir)/libxslt-py.h \
+	   $(srcdir)/libxsltclass.txt
 
 $(GENERATED): gen_prog
 
@@ -69,6 +70,5 @@
 tests test: all
 	cd tests && $(MAKE) tests
 
-clean:
-	rm -f $(GENERATED) *.o libxslt.so *.pyc libxslt.py gen_prog
+CLEANFILES = $(GENERATED) *.o libxslt.so *.pyc libxslt.py gen_prog
 
Index: Makefile.am
===================================================================
--- Makefile.am	(revision 21)
+++ Makefile.am	(working copy)
@@ -46,6 +46,7 @@
 	    -e 's?\@XSLT_LIBS\@?$(XSLT_LIBS)?g' \
 	       < $(srcdir)/xsltConf.sh.in > xsltConf.tmp \
 	&& mv xsltConf.tmp xsltConf.sh
+CLEANFILES = xsltConf.sh
 
 check-local: tests

[bugs about distributed files]
>
>   That's not an oversight, 4-5 are expected, you may want to compile
> on Windows without having the shell/configure/etc... so they need
> to be distributed even if generated when running on Linux/Unix.

ok. thanks.

-- 
gram

Digital signature