RE: [xslt] [PATCH] Updated cygwin support patch

["Igor Zlatkovic" <izlatkovic daenet de>]

Oh, sorry, one small thing.
This patch contains lines like

  +#if !defined LIBEXSLT_PUBLIC
  +#if (defined (__CYGWIN__) || defined _MSC_VER) && \
    !defined IN_LIBEXSLT && !defined LIBXSLT_STATIC
                                     ^^^^^^^^^^^^^^
  +#define LIBEXSLT_PUBLIC __declspec(dllimport)
  +#else
  +#define LIBEXSLT_PUBLIC 
  +#endif
  +#endif

in libexslt.h. The second line is wrong, perhaps I have done this in the past. You see that it checks for libxslt being static, not itself? The emphasised macro above should read LIBEXSLT_STATIC.

Off Topic: 
You know, here in my office, the boss is the one who always makes coffee. He does that because noone else had ever managed to make coffee the way he likes it. Well, what he makes is a bit... strong. You can throw a horseshoe in it and it won't sink :-)
I wish Starbucks or Frazer would open a shop here in this street. Can someone manage that? :-)

Ciao
Igor



> -----Original Message-----
> From: Robert Collins [mailto:robert.collins@itdomain.com.au]
> Sent: Thursday, January 17, 2002 7:53 AM
> To: xslt@gnome.org
> Subject: [xslt] [PATCH] Updated cygwin support patch
> 
> 
> Ok, No automake version requirements this time - but a new header file
> is needed.
> 
> ChangeLog
>     * Makefile.am (SUBDIRS): Move libxslt before it's dependent
> libraries.
>     * libexslt/common.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/date.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/exslt.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/functions.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/math.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/saxon.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/sets.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/strings.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/exslt.h: Export functions referenced in the MSVC .def
> file.
>     * libexslt/exsltconfig.h.in: Include cygwin in the LIBEXSLT_PUBLIC
> Logic.
>     * libexslt/libexslt.h: New header, only include from source going
> into
>     libexslt.
>     * libxslt/libxslt.h: Cygwin has configure, so skip win32 header
> logic.
>     Include cygwin in the LIBXSLT_PUBLIC Logic.
>     * libxslt/libxslt.h:xslt.h: Include cygwin in the LIBXSLT_PUBLIC
> Logic.
>     * libxslt/xsltconfig.h.in: Include cygwin in the LIBXSLT_PUBLIC
> Logic.
>     * libxslt/xsltutils.c: Cygwin has configure, so skip win32 header
> logic.
>     * xsltproc/xsltproc.c: Cygwin has configure, so skip win32 header
> logic.
> 
> Cheers,
> Rob
>