RE: [xslt] [PATCH] Updated cygwin support patch

["Igor Zlatkovic" <izlatkovic daenet de>]

Hi there.

About this:

  -void exsltCommonRegister (void);
  +void LIBEXSLT_PUBLIC exsltCommonRegister (void);
 
This LIBEXSLT_PUBLIC macro is not needed in a function prototype, only in a public variable declaration. 

Are you sure Cygwin needs it? If not, then please, please, remove it. Having this does no harm, but it encourages others to lead endless discussions about putting more in a function prototype, such as the calling convention.

Are you really sure that Cygwin needs this __declspec(*) stuff? I was convinced its GCC can make functional shared and static libraries in the Unix fashion, without needing MS proprietary declaration specificators. Give me some light there.

Ciao
Igor

> -----Original Message-----
> From: Robert Collins [mailto:robert.collins@itdomain.com.au]
> Sent: Thursday, January 17, 2002 7:53 AM
> To: xslt@gnome.org
> Subject: [xslt] [PATCH] Updated cygwin support patch
> 
> 
> Ok, No automake version requirements this time - but a new header file
> is needed.
> 
> ChangeLog
>     * Makefile.am (SUBDIRS): Move libxslt before it's dependent
> libraries.
>     * libexslt/common.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/date.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/exslt.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/functions.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/math.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/saxon.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/sets.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/strings.c: Include new header libexslt.h for it's
> IN_LIBEXSLT logic.
>     Cygwin has configure, so skip win32 header logic.
>     * libexslt/exslt.h: Export functions referenced in the MSVC .def
> file.
>     * libexslt/exsltconfig.h.in: Include cygwin in the LIBEXSLT_PUBLIC
> Logic.
>     * libexslt/libexslt.h: New header, only include from source going
> into
>     libexslt.
>     * libxslt/libxslt.h: Cygwin has configure, so skip win32 header
> logic.
>     Include cygwin in the LIBXSLT_PUBLIC Logic.
>     * libxslt/libxslt.h:xslt.h: Include cygwin in the LIBXSLT_PUBLIC
> Logic.
>     * libxslt/xsltconfig.h.in: Include cygwin in the LIBXSLT_PUBLIC
> Logic.
>     * libxslt/xsltutils.c: Cygwin has configure, so skip win32 header
> logic.
>     * xsltproc/xsltproc.c: Cygwin has configure, so skip win32 header
> logic.
> 
> Cheers,
> Rob
>