Re: [xslt] small bugs in libxml and inconsistancies

[Daniel Veillard <veillard redhat com>]

On Mon, Oct 29, 2001 at 04:52:44PM +1000, Keith Isdale wrote:
> Hi,
> 
> I've posted these bugs to bugzilla but sent a copy for your review
> 
>    Bug id: 63271 posted
> 
> bye,
> 
> Keith 
> ------------------------
> 
> I found some bugs that only affects the breakpoint API. When the input mode 
> of the document is "html" see htmlSAXParseFile (file :HTMLparser.c, line 
> 4873) uses htmlInitParserCtxt (file :HTMLparser.c, line 3663)  but it does 
> not set  the ctxt->linenumbers  value. So no valid breakpoints can be set 
> using "html" mode. Recommend 
>   ctxt->linenumbers = xmlLineNumbersDefaultValue;
> be added near to line 3746

  Sounds right,

> When the input mode of the document is "docbook" see docbInitParserCtxt(file 
> :DOCBparser.c , line 5032)  is used with
>  ctxt->linenumbers = 1;
> which ignores default line number's value. Recommend it be changed to
>   ctxt->linenumbers = xmlLineNumbersDefaultValue;

  Well the DocBook SGML support is a hack, but okay.

> --------------
> 
> Also some *ParseFile functions call 
>   xmlInitParser();
> but others do not (as far as I can tell). This will lead to bugs. :-(.
> One I found was that xmlSAXParseFileWithData (file:  parser.c, line 9747) 
> causes a SEGMENTATION fault when entities are not loaded properly recommend 
>     xmlInitParser();
> be added near line 9751
> 

  Hum, xmlParseDocument calls xmlInitParser() IIRC. To double check, yes.
The segfault comes from a change of the way error routine are initialized
which I have to fix before the next release anyway.

  thanks, will do.

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/