Re: [xslt] Re: Work report/code review part 3

[Daniel Veillard <veillard redhat com>]

On Sun, Oct 21, 2001 at 03:33:36AM +0000, k_isdale@tpg.com.au wrote:
> Hi all,
> 
> Just some comments about my last post. 
> Yes the breakpoint.[ch] was intended to go into 
> the libxslt/ of libxslt library. 

  And I'm not sure it's actaully the right place.
This code is tied to the breakpoint representation
not to the libxslt internal processing. I think it
not required to have it inside and hence would prefer
to have it outside possibly in a separate debugging
library since it can be compiled and run with informations
provided by public headers and manipulate only it's
own defined structures.. But since I have only a
fraction of the code needed for the integration I
can't really make a final decision.

> Reguarding xsltaddon I understand the problem 
> with main() being in a library. 
> 
> >problem to be correct. The
> > entity loader code from xsltproc culd be 
> migrated onto libxslt, xsltProcess
> > could be made rusable by using parameters 
> instead of global variables
> > and extracted too, but trying to turn the whole 
> thing as a library, including
> 
> Yes please !! 
> 
> I think there is now steps 
>  1) finalizing the breakpoint API.  (See my next 
> post to libxslt)
>  2) put the re-usable code from xsltproc into a 
> libxslt (fiddly but no a big problem. Rewrite 
> some of xsltproc code?)
>  3) rewriting xsldbg code to make use of the 
> functions added by step 2 (fiddly but no a big 
> problem.) 
> 
> Steps 1 and 3 I'll do when I can 
> Step 2 I'd like some else to tackle (will have no 
> impact on the breakpoint API)

  Okay, I will try to do that since I suggested it.

> In my next post I'll have a clean patch for 
> libxslt-1.0.5 (still using xsltaddon :-( , and 
> xsldbg plus its xemacs mode for debugging 
> stylesheets. 
> 
> p.s. 
> Daniel, When setting a value of a variable using 
>   xsltSetVariable do you need to supply a copy of 
> the intended new value after freeing the old 
> value?

  Hum, there is no xsltSetVariable() call. Currently
variable are set by:
    xsltParseGlobalVariable/xsltEvalGlobalVariables
    xsltParseGlobalParam/xsltEvalUserParams
  and the interpreter when it finds a precompiled 
variable declaration in the tree.

> What include file do I need for this? I 
> can't seem to find a mention of these functions, 
> strange. 

  Right because they were never needed.

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/