Re: [xslt] Debug by default still

[Matt Sergeant <matt sergeant org>]

On Tue, 17 Jul 2001, Daniel Veillard wrote:

> On Tue, Jul 17, 2001 at 03:46:45PM +0100, Matt Sergeant wrote:
> > On Tue, 17 Jul 2001, Daniel Veillard wrote:
> >
> > > On Tue, Jul 17, 2001 at 09:55:57AM +0100, Matt Sergeant wrote:
> > > > Now that we've past 1.0, can we turn debug messages off by default? I get
> > > > this question all the time on the AxKit list (or sent direct to me), and
> > > > it's becoming rather frustrating to have to tell everyone to recompile
> > > > with --without-debug.
> > >
> > >   Err, and what's the reason ? Size or speed ? I did made some
> > > profiling and found out it accounted to less than 1% of the processing
> > > time on most tests, as a result I decided that this 1% was worth keeping
> > > in the released libraries in order to be able to debug things easilly
> > > (like allowing -v to xsltproc).
> > >   Can you try to get an idea why people are objecting doing this ?
> >
> > Just fills your error log with crap (when run under AxKit), making it hard
> > to see what's actually going on with AxKit.
>
>   Then it's AxKit error it seems.
> the xsltproc command don't generate error messages by default,
> simply do the same :
>   xsltSetGenericDebugFunc(NULL, NULL);
>
> should be sufficient, unless I'm missing something.

Maybe you are... Or maybe I am...

In LibXSLT.xs, at boot time we do:

  LibXSLT_debug_cb = NULL;
  xsltSetGenericDebugFunc(PerlIO_stderr(), (xmlGenericErrorFunc)LibXSLT_debug_handler);

And then in LibXSLT_debug_handler:

    if (LibXSLT_debug_cb && SvTRUE(LibXSLT_debug_cb)) {
      ... call the handler
    }

Otherwise we do nothing with the message.

Now in AxKit, we don't set that debug callback at all. Not anywhere. Yet
errors still go to STDERR.

-- 
<Matt/>

    /||    ** Founder and CTO  **  **   http://axkit.com/     **
   //||    **  AxKit.com Ltd   **  ** XML Application Serving **
  // ||    ** http://axkit.org **  ** XSLT, XPathScript, XSP  **
 // \\| // ** mod_perl news and resources: http://take23.org  **
     \\//
     //\\
    //  \\