Re: [xml] [PATCH] Fix xmlURIEscape memory leaks.



thanks! took a while for the fuzzing infrastructure to catch up, but
it's looking good now.

hopefully you won't hear from me again, but i'll be back with another
patch if the fuzzers find anything else :-)

On Mon, Nov 9, 2020 at 9:32 AM Nick Wellnhofer <wellnhofer aevum de> wrote:

Merged here:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/7c06d99e1f4f853e3c5b307c0dc79c8a32a09855

Nick

On 27/10/2020 19:33, enh via xml wrote:
Found by running the fuzz/uri.c fuzzer under asan (internal Android bug
171610679).

Always free `ret` when exiting on failure. I've moved the definition of
NULLCHK down past where ret is always initialized to make it clear that
this is safe.

This patch also fixes the indentation of two of the NULLCHK call sites
to make it more obvious that NULLCHK isn't `if`-like.
---
  uri.c | 17 +++++++++--------
  1 file changed, 9 insertions(+), 8 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]