Re: [xml] [PATCH] Fix xmlURIEscape memory leaks.



ping?

(let me know if this should be a pull request somewhere instead...)

On Tue, Oct 27, 2020 at 11:33 AM enh <enh google com> wrote:

Found by running the fuzz/uri.c fuzzer under asan (internal Android bug
171610679).

Always free `ret` when exiting on failure. I've moved the definition of
NULLCHK down past where ret is always initialized to make it clear that
this is safe.

This patch also fixes the indentation of two of the NULLCHK call sites
to make it more obvious that NULLCHK isn't `if`-like.
---
 uri.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]