Re: [xml] Patch to fix ICU flush and pivot buffer

From: Joel Hockey <joelhockey chromium org>
To: Nick Wellnhofer <wellnhofer aevum de>
Cc: Markus Scherer <mscherer google com>, "xml gnome org" <xml gnome org>, Jungshik Shin <jshin chromium org>, Markus Scherer <markus icu gmail com>
Subject: Re: [xml] Patch to fix ICU flush and pivot buffer
Date: Thu, 9 Nov 2017 10:22:28 +1100

Thanks Nick. Nice work with the test.

On Sun, Nov 5, 2017 at 2:04 AM, Nick Wellnhofer <wellnhofer aevum de> wrote:

On 26/10/2017 03:17, Joel Hockey wrote:

I've updated the patch using git format-patch.

Thanks for the updated patch. Applied here: https://git.gnome.org/browse/libxml2/commit/?id=0b19f236a263a7b0acacd4ea84dc7237303ee3d9

The original bug found by fuzzer only relates to UTF8 decoding, so using Shift-JIS or anything else wont help.

Why not? My reasoning was that ICU uses the same code path for all variable-width encodings. I simply converted your test file to EUC-JP and it turns out that this triggers the bug as well:

https://git.gnome.org/browse/libxml2/commit/?id=72182550926d31ad17357bd3ed69e49d7e69df02

Nick

References:
- Re: [xml] Patch to fix ICU flush and pivot buffer
  - From: Nick Wellnhofer

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]