Re: [xml] win32\VC10\config.h and VS 2015

[Michael Stahl <mstahl redhat com>]

On 07.03.2016 22:46, Bruce Dawson wrote:
> The config.h file in win32\VC10 is incompatible with VS 2015 because VS
> 2015 provides an implementation of snprintf and prohibits using the
> preprocessor to define it. Therefor an ifdef check is needed around that
> definition in VC10\config.h. Here is a patch that is compatible with the
> change that we made to Chromium's copy:
>
>
> diff --git a/win32/VC10/config.h b/win32/VC10/config.h
> index 8629944..891b57e 100644
> --- a/win32/VC10/config.h
> +++ b/win32/VC10/config.h
> @@ -96,7 +96,9 @@ static int isnan (double d) {
>
>  #if defined(_MSC_VER)
>  #define mkdir(p,m) _mkdir(p)
> +#if _MSC_VER < 1900 // Cannot define this in VS 2015 and above!
>  #define snprintf _snprintf
> +#endif
>  #if _MSC_VER < 1500
>  #define vsnprintf(b,c,f,a) _vsnprintf(b,c,f,a)
>  #endif
>
>
> It would be great to get that same patch in libxml2, and other
> developers will need it if they use VC10\config.h.

it looks like release 2.9.3 already includes this fix, i've had to
remove a similar patch when upgrading LibreOffice's bundled copy :)