Re: [xml] [patch] Fix wrong argument type in functino xmlSchemaValidateLengthFacetInternal

[Nico Weber <thakis chromium org>]

On Tue, Feb 28, 2012 at 5:45 PM, Daniel Veillard <veillard redhat com> wrote:
> On Tue, Feb 28, 2012 at 09:42:03AM -0800, Nico Weber wrote:
> > Hi,
> >
> > the attached patch fixes the following warning in libxml:
> >
> > [1902/9563] CC obj/third_party/libxml/src/libxml.xmlschemastypes.o
> > ../../third_party/libxml/src/xmlschemastypes.c:5188:12: warning: case
> > value not in enumerated type '' [-Wswitch]
> >            case XML_SCHEMAS_NOTATION:
> >                 ^
> > ../../third_party/libxml/src/xmlschemastypes.c:5183:11: warning: case
> > value not in enumerated type '' [-Wswitch]
> >            case XML_SCHEMAS_ANYURI:
> >                 ^
> > 2 warnings generated.
> >
> > valType has type xmlSchemaTypeType, but all the enums listed in the
> > switch are in xmlSchemaValType. It looks like the right fix is to just
> > fix the function interface.
>
>  Agreed that was clearly a bug, wrong enum ! thanks, applied :-)

Thanks!

https://bugzilla.gnome.org/show_bug.cgi?id=651202 is another patch
that we (chromium) posted a while ago. Looks like things sent to the
list get picked up faster :-) Maybe you could land that, too?

Nico