Re: [xml] [PATCH] Various "make distcheck" and portability fixups

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 06, 2012 at 03:28:02PM -0400, Daniel Richard G. wrote:
> On Mon, 6 Aug 2012, Daniel Veillard wrote:
>
> > Never too late, I guess, I managed to apply the patch. Well some parts
> > had to be done manually as a bit of the git head has changed since then.
> > I was tempted to split the different parts but in the end I'm not sure
> > it matters much. So I pushed the whole set of fix in one blob:
>
> Thanks for getting this in :)
>
> > if you could double check I didn't made mistakes on the parts I had
> > to do manually, that would be great,
>
> Only a bit of touching-up is needed, plus a couple of fixes that
> came by the way later. The attached patch takes care of these.
> Walking through:
>
> doc/examples/Makefile.am:
>
> * Use $(VAR), not @VAR@
>
> * Use $(MKDIR_P) instead of $(mkinstalldirs), as the latter is an obsolete
>   name
>
> * Added $(srcdir) qualification to the various test program invocations in
>   the "tests" target. More work is needed here (notably, when the
>   reference output contains the path to the input file), but this gets
>   things a lot closer to working correctly in an out-of-source build.
>
> doc/examples/reader4.res:
>
> * Added "./" path qualifiers so that the reader4 test continues to pass
>   cleanly for in-source builds
>
> python/tests/Makefile.am:
>
> * Symlink in test input files for out-of-source builds

  Okay makes sense pushed too,


> I've also submitted a patch for a runtest thread-support bug at
>
>       https://bugzilla.gnome.org/show_bug.cgi?id=680539
>
> which has been a problem on proprietary-Unix builds.

  Yes I agree with he description and proposed fix, so applied and
pushed to git,

  thanks a lot !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/