Re: [xml] Get rid of a likely typo in xpath.c



On Mon, Oct 11, 2010 at 09:25:15PM +0200, Marius Wachtler wrote:
Hello

My compiler is warning me about a likely typo in
xpath.c:xmlXPathCompOpEvalFirst()

#ifdef XP_OPTIMIZED_FILTER_FIRST
       case XPATH_OP_FILTER:
               total =+ xmlXPathCompOpEvalFilterFirst(ctxt, op, first);
           return (total);
#endif

I think the =+ should be +=, however "total" is zero initialized so
this should not make any difference.

 Gahhh ... I wonder for how many years this went unnoticed, since 2006
apparently !

Pushed the fix to git, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]