Re: [xml] uri.c vs RFC 3986

[Daniel Veillard <veillard redhat com>]

On Thu, Jun 03, 2010 at 11:38:26AM +0200, François Delyon wrote:
> In uri.c,
>
> #define ISA_SUB_DELIM(p)                                              \
>       (((*(p) == '!')) || ((*(p) == '$')) || ((*(p) == '&')) ||               \
>        ((*(p) == '(')) || ((*(p) == ')')) || ((*(p) == '*')) ||               \
>        ((*(p) == '+')) || ((*(p) == ',')) || ((*(p) == ';')) ||               \
>        ((*(p) == '=')))
>
> This does not conform to the RFC 3986. The character apos is missing.
> RFC -> sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" /
> "," / ";" / "="
> Consequently, libxml2 breaks with URI containing unescaped apos
> characters.
>
> Is there a particular motivation to remove the apos character or is
> this a bug?

  Weird, I double checked the RFC and googled a bit, I remember there
  was one issue with one character at some point, but I don't remember
what it was really about :-)
 Making the change seems to let 'make check' pass without problems,
so I pushed the fix,

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/