Re: [xml] Test suite errors 2.7,7

[Todd Rinaldo <toddr cpanel net>]

On Apr 6, 2010, at 7:20 AM, Daniel Veillard wrote:

> On Thu, Apr 01, 2010 at 12:18:44PM -0500, Todd Rinaldo wrote:
> > I am experiencing test suite errors on bare bones installs of CentOS 3 and 4 64 bit with libxml2 version 
> > 2.7.7. I am building from a custom source rpm. The relevant spec bits can be seen at the end of this 
> > email. I build this spec against numerous Red Hat derivative  targets. For some reason it's succeeding on 
> > CentOS-5-64. It's also failing on some of the older fedoras in my checks so far.
> >
> > Are there any additional dependencies not mentioned in your standard spec file that might be causing these 
> > tests to fail?
> >
> > The error message seems to be consistent:
> >
> > File ./test/ebcdic_566012.xml generated an error
> > File ./test/ebcdic_566012.xml generated an error
> > File ./test/ebcdic_566012.xml generated an error
> > Result for ./test/ebcdic_566012.xml failed
> > File ./test/ebcdic_566012.xml generated an error
> > Result for ./test/ebcdic_566012.xml failed
> > File ./test/ebcdic_566012.xml generated an error
> > Result for ./test/ebcdic_566012.xml failed
> > File ./test/ebcdic_566012.xml generated an error
> > Failed to parse ./test/ebcdic_566012.xml
> > File ./test/ebcdic_566012.xml generated an error
> > Failed to parse ./test/ebcdic_566012.xml
> > File ./test/ebcdic_566012.xml generated an error
> > Failed to parse ./test/ebcdic_566012.xml
> > File ./test/ebcdic_566012.xml generated an error
> > Failed to parse ./test/ebcdic_566012.xml
> > File ./test/ebcdic_566012.xml generated an error
>
>  Works for me on a RHEL-5.4 x86_64.
> run
>
> xmllint ./test/ebcdic_566012.xml
>
> and compare the output with  result/ebcdic_566012.xml

Hi, Thanks for your response. 

Your requested test on CentOS 3 x86_64
./xmllint ./test/ebcdic_566012.xml
Segmentation fault

# gdb .libs/lt-xmllint core.31606 
...
This GDB was configured as "x86_64-redhat-linux-gnu"...Using host libthread_db library 
"/lib64/tls/libthread_db.so.1".
...
Core was generated by `/home/rpmbuild/rpm-build/BUILD/libxml2-2.7.7/.libs/lt-xmllint ./test/ebcdic_566'.
Program terminated with signal 11, Segmentation fault.
(gdb) bt
#0  0x0000002a95e664f4 in strncmp () from /lib64/tls/libc.so.6
#1  0x0000002a956e6dc8 in __xmlParserInputBufferCreateFilename (URI=0x7fbfffdba6 "./test/ebcdic_566012.xml", 
enc=XML_CHAR_ENCODING_NONE) at xmlIO.c:2528
#2  0x0000002a956e6e57 in xmlParserInputBufferCreateFilename (URI=0x7fbfffdba6 "./test/ebcdic_566012.xml", 
enc=XML_CHAR_ENCODING_NONE) at xmlIO.c:2563
#3  0x0000002a956adfb1 in xmlNewInputFromFile (ctxt=0x51d490, filename=0x7fbfffdba6 
"./test/ebcdic_566012.xml") at parserInternals.c:1549
#4  0x0000002a956e8d6f in xmlDefaultExternalEntityLoader (URL=0x7fbfffdba6 "./test/ebcdic_566012.xml", 
ID=0x0, ctxt=0x51d490) at xmlIO.c:3885
#5  0x0000000000404bfa in xmllintExternalEntityLoader (URL=0x7fbfffdba6 "./test/ebcdic_566012.xml", ID=0x0, 
ctxt=0x51d490) at xmllint.c:282
#6  0x0000002a956e8e5e in xmlLoadExternalEntity (URL=0x7fbfffdba6 "./test/ebcdic_566012.xml", ID=0x0, 
ctxt=0x51d490) at xmlIO.c:3945
#7  0x0000002a956cf463 in xmlCreateURLParserCtxt (filename=0x7fbfffdba6 "./test/ebcdic_566012.xml", 
options=65536) at parser.c:13388
#8  0x0000002a956d0e1d in xmlReadFile (filename=0x7fbfffdba6 "./test/ebcdic_566012.xml", encoding=0x0, 
options=65536) at parser.c:14541
#9  0x000000000040854a in parseAndPrintFile (filename=0x7fbfffdba6 "./test/ebcdic_566012.xml", rectxt=0x0) at 
xmllint.c:2376
#10 0x000000000040c367 in main (argc=2, argv=0x7fbfff9bb8) at xmllint.c:3680
(gdb) 

The offending call appears to be strncmp(buff4, cptr, 4);

My guess would be that the cause is that cptr isn't being checked at: cptr = (char *) ((z_stream 
*)context)->next_in;

Guessing from the code, I think it might be important to know that I have this zlib installed: 
zlib-1.1.4-10.EL3

This is definitely happening on Centos 3 and 4 and my tests show no failure on 5. Removing this test allows 
the rest of the suite to succeed.

Thanks,
Todd