Re: [xml] xmllib2-2.6.32 on x86_64



Hello,

well I don't think you could do so.
Infact the compiler returns me:

xmlreader.c: In function 'xmlTextReaderBuildMessage':
xmlreader.c:4511: error: 'va_start' used in function with fixed args
make[2]: *** [xmlreader.lo] Error 1
make[2]: Leaving directory `/root/devel/libxml2-2.6.32'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/devel/libxml2-2.6.32'
make: *** [all] Error 2

Moreover, may be I could be wrong, but the ap_start related to ap
parameter is in calling function (i.e. xmlTextReaderError) and it
should't be called in xmlTextReaderBuildMessage function too.
What's wrong with va_copy?
Anyway, you added an extra check on size, and this is really good.

Regards

-- 
R.Scussat
DSPLABS Srl
dsplabs dsplabs net
PGP Key ID: 0x618E24FE




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]