Re: [xml] Useless function calls in xmlSetProp()?

[Daniel Veillard <veillard redhat com>]

On Fri, Feb 08, 2008 at 05:17:31PM +0100, Julien Charbon wrote:
> Daniel Veillard wrote:
> > On Mon, Jan 28, 2008 at 03:26:02PM +0100, Julien Charbon wrote:
> > > Hum, sure, UTF-8 validation shall not be removed. Anyway to evaluate 
> > > this extra complexity, I made the simple program [see below] that do 
> > > 1000 iterations of xmlSetProp(node, name, value) and calculate the sum 
> > > of all these calls with various 'value' parameter:
> >
> >  okay, this makes a difference, agreed, is that really perceptible
> > on a real application run ? I'm unsure ...
>
>  True. On our application, performance improvement is between 0.5 - 
> 0.7%. More than nothing, but certainly not a super fast revolution...
>
> > > Patch applied to current libxml2 trunk:
> >
> >   But I tend to like the patch for a few reasons:
> >     - it cleans things up and show the actual process
> >     - it enforces the UTF-8 check in a clear manner
> >     - it doesn't change apparently the actual behaviour of the API
> >
> > > == tree.c.patch ==
> >  The patch looks fine to me, if you can provide the final version as an
> > email attachment, I will try to apply it,
>
>  Seems fine and clear. Attached to this email the "final" patch 
> against current trunk.

  okidoc, rereviewed it, it looks fine, applied, tested still fine, so I
commited it, thanks a lot !
  In completely unscientific testings, runtest number of allocs are reduced
from 3,058,476 to 3,053,663 which is around 0.15% , it really depends on
the kind of documents used and what processing.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/