Re: [xml] Regarding Malloc Failure Handling--Patch for Parser.c

[Ashwin <ashwins huawei com>]

  Right,

>  so I applied manually all changes, modifying a few things, might be worth
> re-checking from SVN head (rev 3720),

I think this one is missed out

*************** xmlParseAttValueComplex(xmlParserCtxtPtr
*** 3280,3286 ****
                    }
                } else if ((ent != NULL) && 
                           (ctxt->replaceEntities != 0)) {
!                   xmlChar *rep;
  
                    if (ent->etype != XML_INTERNAL_PREDEFINED_ENTITY) {
                        rep = xmlStringDecodeEntities(ctxt, ent->content,
--- 3297,3303 ----
                    }
                } else if ((ent != NULL) && 
                           (ctxt->replaceEntities != 0)) {
! 
  
                    if (ent->etype != XML_INTERNAL_PREDEFINED_ENTITY) {
                        rep = xmlStringDecodeEntities(ctxt, ent->content,

The xmlChar *rep decl is right at the beginning of the function and needs to
be removed from here....

And in the patch I sent for realloc, the null check for realloc is still
being done for the original pointer rather than against the temp pointer for
the functions nsPush and spacePush, it was an oversight on my part...Sorry
about that!

Regards
Ashwin