Re: [xml] [PATCH] xmlIO HTTPS handler using libcurl [version 2]

Daniel Veillard wrote:
On Wed, Mar 21, 2007 at 01:38:43PM -0400, joel reed wrote:
Yes I agree another dependency is annoying. We are doing forms based authentication over SSL here, so the need to handle http basic/digest type authentication hasn't come up but I can see the usefulness for others.

  I see,

One thing I had considered is making the curl patch handle http, https, ftp, sftps, and whatever else ( libcurl can handle that would be of interest for xmlIO. As part of that I could add an authentication callback.

Could we say that if you enable curl support, nano http/ftp handlers are disabled at compile time or would you like to approach it some other way? (if the above sounds interesting) If the dependency is really too annoying, no problem, patch can sit on mailing list for others if they need it.

  I tend to think that if we integrate curl support then let's do it
fully, and avoid the nano side of things. Then the configure option would really be useful to a larger audience.
  At this point my take is that an optional feature plugging curl fully
replacing the nano modules and adding authentication would makes a
lot more sense than a limited plug, and that should be added to the default code base because a lot more users are likely to use/debug/fix
potential problems.

   Makes sense ?


I think I'll rename this thing curlIO.{h,c}. Any thoughts on configuration API? I think I need to change xmlIO to call a configuration callback function or some such thing, as my current xmlIOHTTPSSetup approach is library wide, but what we really want is a context specific configuration capability. Also, I'm not sure it makes sense to wrap every possible curl configuration option ( I'm thinking if there was a callback that got the context pointer, maybe all we need is a function which returns the CURL*, then the application could use whatever CURL config options were available. There are a ton of curl config options. Does this sound OK?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]