Re: [xml] Replace 2 shl_findsym() calls in xmlmodule with 1

[Daniel Veillard <veillard redhat com>]

On Fri, Oct 28, 2005 at 08:43:27AM -0500, Albert Chin wrote:
> Why do you have two calls to shl_findsym on HP-UX? From the shl_load
> man page:
>            ...  The type argument specifies the expected type for
>            the symbol, and should be one of the defined constants
>            TYPE_PROCEDURE, TYPE_DATA, or TYPE_UNDEFINED.  The latter value
>            suppresses type checking.  These are the only accepted type
>            arguments on PA-RISC 64-bit systems.  On PA-RISC 32i-bit systems,
>            you can also specify TYPE_STORAGE, or TYPE_TSTORAGE. ...
>
> libltdl in libtool uses TYPE_UNDEFINED. Perl uses
> TYPE_PROCEDURE/TYPE_DATA like you do now. Python and Glib use
> TYPE_UNDEFINED. Why be so specific? The user should know what symbol
> they're looking for so we're just interested in resolving the symbol,
> regardless of the type. This simplifies the code as well.
>
> Patch against 2.6.22 (will collide with my recent shl_findsym() patch
> to get it working on HP-UX).

  Okay, makes sense too, applied, will commit !

    thanks !

daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/