Re: [xml] One more possible bug in xmlregexp.c

[Sreeni Nair <sreeni nair gmail com>]

No tools; I was just reading the code to find out how the automata are
constructed ( I haven't figured that out still :-)).

On 12/29/05, Daniel Veillard <veillard redhat com> wrote:
> On Wed, Dec 28, 2005 at 06:37:34PM -0500, Sreeni Nair wrote:
> > In xmlregexp.c, on or around line number 5122, the current code reads
> >
> >     ctxt->start = ctxt->state = xmlRegNewState(ctxt);
> >     ctxt->start->type = XML_REGEXP_START_STATE;
> >     if (ctxt->start == NULL) {
> >       xmlFreeAutomata(ctxt);
> >       return(NULL);
> >     }
> >
> > The check against NULL should come before the assignment of
> > XML_REGEXP_START_STATE, I think.
>
>   Right, good catch. Is that the output of a manual review or do you have
> an automated tool to check those ?
>
>   Fix applied, will commit soon,
>
>    thanks !
>
> Daniel
>
> --
> Daniel Veillard      | Red Hat http://redhat.com/
> veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/