Re: [xml] purify related patches



On Wed, Sep 22, 2004 at 12:25:34PM -0700, Mark Vakoc wrote:
(originally sent using wrong e-mail..)


While running Purify [Windows] on my application I found some minor problems.

Patches attached.

uri.diff: xmlURIUnescape has an unitialized memory read by reading beyond the
passed in buffer length

threads.diff [windows] : the thread's (global state) xmlLastError is not
freed
on thread termination so there could be a leak or two

If I find anymore I'll send some more patches.

  Cool, they both make sense. I'm surprized the python test thread2.py
didn't raise the potential memory leak when a thread makes a parsing
error. 

  thanks a lot, applied, I expect to commit it as soon as my valgrind tests
finishes,

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]