Re: [xml] [PATCH] DSO/Module Support

[Joel Reed <joelwreed comcast net>]

On Wed, Dec 22, 2004 at 07:06:30PM +0100, Bjorn Reese wrote:
> Joel Reed wrote:
>
> > thanks for pointing this out. i was about to address this, but noticed
> >
> > that NULL is a not valid address on win32, so in the interest of 
> > promoting
> > cross-platform compatability in a library that's known for its
> > cross-platform compatability, and given this would seem to be a corner
> > case not frequently used, it seems better to leave as-is.
> I disagree. If you want cross-platform compatibility, then you should 
> not ignore potential errors that may occur in one platform.

i don't see how this is ignoring potential errors. you've said
NULL is valid on dlopen platforms. i said NULL is not valid on win32.
so, the current code limits dlopen platforms (in what would seem
to be a corner case) to not allow NULL as valid. i don't feel strongly
about this but it doesn't seem like terribly compelling argument to me.

> You could let xmlModulePlatformSymbol return the pointer as an out
> parameter, and use the return value to indicate success or failure.

yes, a good way to code the alternative.

jr