[xml] [PATCH] HTTP resource escaping/unescaping fails with quoted URLs

On Thu, Dec 12, 2002 at 04:43:49PM -0500, Daniel Veillard wrote:
  and provide a patch. Make it checked for Windows paths and verify it
passes asll libxml2 and libxslt regression tests. Then you issue
will get fixed promptly if you don't suggest to make silly things
like changing APIs

I attach a patch that seems to solve the problem without changing any
API, the patch applies cleanly to libxml2 2.5.1.

I attach also the two execution logs of regression tests of libxslt1 and
libxml2, there are some warning that seems to be undocumented (i.e. not
like the absence of 'title.xml' that is previously announced) could you
please have a look at them?

Here is a small log of what I have done:
- removed the URI unescaping of URIs from
- added it in xmlFileOpen and xmlGzfileOpen with a fallback on the raw
  URI if the function fails with the unescaped URI to preserve the
  previous behaviour that do the same but outside the two xml*Open
- left xml*Match function as before because IMHO the URI scheme test has
  to be done on the URI before unescaping it (because in turn the
  escaping may depend on the URI scheme as in our case: it has to be
  considered different if the URI is an HTTP URI or a filename)
- removed the URI escaping from xmlNanoHTTPNewCtxt because now the URI
  reach this function untouched
- added the URI unescaping in xmlNanoFTPScanURL with fallback on the raw
  URI in case of failure to preserve the previous behaviour

Tell me if the patch may find its way in the CVS or what additional
changes do you like to see in order to accept it.

BTW you have closed the bug reported by me regarding xmlBuildURI, but
remember that the problem isn't really solved, it's only fixed for
absolute URIs, relative ones still suffer of the reported problem.


Stefano Zacchiroli  -  Undergraduate Student of CS @ Uni. Bologna, Italy
zack {cs unibo it,debian.org,bononia.it}  -  http://www.bononia.it/zack/
"  I know you believe you understood what you think I said, but I am not
sure you realize that what you heard is not what I meant!  " -- G.Romney

Attachment: libxml2.regtest.txt.gz
Description: Binary data

Attachment: libxml2_unescaping.patch
Description: Text document

Attachment: libxslt1.regtest.txt.gz
Description: Binary data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]