[xml] Re: libxml2; source code typo bug

[Daniel Veillard <veillard redhat com>]

On Tue, Dec 30, 2003 at 04:28:01PM +1300, Morgan L. Owens wrote:
> Jus thought I'd mention this: in the function xmlSchemaCompareDecimals() 
> (xmlschematypes.c) are the lines:
>
>    if (x->value.decimal.hi < y->value.decimal.hi)
>        return (-order);
>    if (x->value.decimal.hi < y->value.decimal.hi)
>        return (order);
>    if (x->value.decimal.mi < y->value.decimal.mi)
>        return (-order);
>    if (x->value.decimal.mi < y->value.decimal.mi)
>        return (order);
>    if (x->value.decimal.lo < y->value.decimal.lo)
>        return (-order);
>    if (x->value.decimal.lo > y->value.decimal.lo)
>        return(order);
>
> Clearly, the second and fourth comparisons are backwards, and the lines 
> ought to be:
>
>    if (x->value.decimal.hi < y->value.decimal.hi)
>        return (-order);
>    if (x->value.decimal.hi > y->value.decimal.hi)
>        return (order);
>    if (x->value.decimal.mi < y->value.decimal.mi)
>        return (-order);
>    if (x->value.decimal.mi > y->value.decimal.mi)
>        return (order);
>    if (x->value.decimal.lo < y->value.decimal.lo)
>        return (-order);
>    if (x->value.decimal.lo > y->value.decimal.lo)
>        return(order);

  That sounds right, but the proper way to report such problems is
indicated at 
   http://xmlsoft.org/bugs.html
  I'm carbon-copying the mailing-list for archival,

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/