Re: [xml] [PATCH] Javascript wrapped up in comments

On Thu, Nov 08, 2001 at 08:42:36AM -0500, Daniel Veillard wrote:
On Thu, Nov 08, 2001 at 02:06:29PM +0100, The Dude wrote:
yet another little fix for HTMLparse.c:
The following Javascript is not parsed correctly:


The attached patch fixes this by parsing javascript wrapped up in comments.

  Sorry, your script is incorrect.

  It basically handled the tiny case you presented but's that's all,
breaking everything else !
Multiple comments on a script element would not be parsed, it breaks
the push parser, loose surrounding context of the comment, etc, etc.
Just for fun try to use it on test/HTML/doc3.htm in the regression tests !!!

  I spent the time to make a correct patch:


P.S.: You should definitely change your .sig, it is offensive, and IMHO you
      are not in a position to defend it, especially in this conext !

Daniel Veillard      | Red Hat Network
veillard redhat com  | libxml Gnome XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]