Re: [xml] [PATCH] Javascript wrapped up in comments

[Daniel Veillard <veillard redhat com>]

On Thu, Nov 08, 2001 at 08:42:36AM -0500, Daniel Veillard wrote:
> On Thu, Nov 08, 2001 at 02:06:29PM +0100, The Dude wrote:
> > yet another little fix for HTMLparse.c:
> > The following Javascript is not parsed correctly:
> >
> > <script>
> > <!--
> > self.document.write("<b></b>");
> > -->
> > </script>
> >
> > The attached patch fixes this by parsing javascript wrapped up in comments.
>
>   Sorry, your script is incorrect.

  It basically handled the tiny case you presented but's that's all,
breaking everything else !
Multiple comments on a script element would not be parsed, it breaks
the push parser, loose surrounding context of the comment, etc, etc.
Just for fun try to use it on test/HTML/doc3.htm in the regression tests !!!

  I spent the time to make a correct patch:

http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-xml&branch=HEAD&branchtype=match&dir=gnome-xml&file=&filetype=match&who=veillard&whotype=match&sortby=Date&hours=&date=explicit&mindate=11%2F10%2F01+06%3A42&maxdate=11%2F10%2F01+06%3A44&cvsroot=%2Fcvs%2Fgnome

Daniel

P.S.: You should definitely change your .sig, it is offensive, and IMHO you
      are not in a position to defend it, especially in this conext !
      http://mail.gnome.org/archives/xml/2001-November/msg00052.html

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/