Re: [xml] Still some words about XPath

On Mon, May 14, 2001 at 05:59:42PM +0200, Thomas Broyer wrote:

Here are some remarks about the XPath module, more may come later.

 · is there any good reason not to have a function xmlXPathNewObject
   instead of copying the allocation code in every xmlXPathNew*

  Might make sense. On the other hand it's one more function call
in a relatively critical path.

 · xmlXPathNewNodeSet returns an "empty node-set" object when it is
   passed NULL, whereas xmlXPathNewNodeSetList returns NULL and
   xmlXPathWrapNodeSet returns an empty object (obj->nodesetval is
   xmlXPathNewNodeSet is consistant with xmlXPathNewString and

  Yes this makes sense, there is places where one want to create
the node set "before" for example before a loop without failing.

 · is there any good reason keeping unused structures and types in

  Once it's public, it's public until a new API breakage, i.e. libxml3
maybe never... they are probably reused in xpathInternals.h too.


Daniel Veillard      | Red Hat Network
veillard redhat com  | libxml Gnome XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]