Re: [xml] Using libiconv

[xml thewrittenword com]

On Tue, Jul 03, 2001 at 06:47:07PM +0200, Tomasz K³oczko wrote:
> On Tue, 3 Jul 2001 xml thewrittenword com wrote:
>
> > On Tue, Jul 03, 2001 at 10:40:50AM -0400, Daniel Veillard wrote:
> > > On Tue, Jul 03, 2001 at 09:13:25AM -0500, xml thewrittenword com wrote:
> > > > Then how about we add --with-iconv=DIR which allows you to specify the
> > > > parent include/lib directory for iconv? All this would really do is
> > > > add DIR/include to $CPPFLAGS and DIR/lib to $LDFLAGS.
> > >
> > >   Albert, this sounds the Right Way (TM), would you be kind enough
> > > to provide such a patch ?
> >
> > Ok, how's the following? I tested on Solaris 7/SPARC and it seems to
> > work fine (with system iconv and libiconv 1.6.1).
> >
> > Should we change the --with-iconv description in ./configure --help?
>
> --
>  else
> -    AC_CHECK_HEADER(iconv.h, 
> -       AC_CHECK_FUNC(iconv, ,
> -           AC_CHECK_LIB(iconv, iconv, ICONV_LIBS="-liconv")))
> -    if test "$have_iconv" != "" ; then
> -        echo Iconv support not found
> -        WITH_ICONV=0
> -    else
> -        WITH_ICONV=1
> +    if test "$with_iconv" != "yes" ; then
> +       CPPFLAGS="${CPPFLAGS} -I$with_iconv/include"
> +       ICONV_LIBS="-L$with_iconv/lib"
> --
>
> Sorry but this kind modyfication it is plain/big step back.
> Instead patching configure.in use natural autoconf abilities and run
> configure by:
>
> $ CFLAGS="-I<iconv_prefix>/include" LDFLAGS="-L<iconv_prefix>/lib" ./configure

It won't work because you're using GNU libiconv with the system
iconv.h. They are incompatible. The only way to properly check for
-liconv is to AC_TRY_LINK and include iconv.h. You cannot do this with
AC_CHECK_LIB. Brian Stafford was right about this.

-- 
albert chin (china thewrittenword com)