Re: [xml] Patches to 2.3.4

On Tue, Mar 27, 2001 at 08:09:04AM -0500, Daniel Veillard wrote:
On Wed, Mar 21, 2001 at 11:58:56AM -0600, xml thewrittenword com wrote:
1. On Solaris 2.5.1 and IRIX 6.2, snprintf is *not* available. So,
   I copied in the snprintf.c from the Samba distribution and
   added an autoconf test to compile and link it into libxml2.
   If we do not link snprintf into libxml2, then *every* program
   that links against libxml2 will need snprintf.c compiled into
   it (like xmllint).

   Okay since I also got a report that 2.3.5 was simply crashing
because of those issues:

   I have tried to get rid for good of this string functions
portability and the security nightmare of using sprintf or vsprintf.

   Basically I will follow your approach i.e. embedd rimplementation
of the missing functions, except I will try to use the trio library
of string functions:

   Main argument for selecting those is that Bjorn Reese is one of the
coauthors and hence we have pretty good chance to get things fixed 
promptly in case of troubles.

   I have put an updated test distribution at:

 and i would really like feedback on the portability of the resulting code.
This is a rather large change and I would prefer early feedback before 
making a full release with this,

Well, I kinda thought your reasoning for not including my patch made
perfect sense. After reading what you wrote, it made sense to me not
to solve this at the library level. If the trio reimplentation of
snprintf and friends were compiled in, would they be exported symbols
to client programs? If so, I think that's a mistake. The clients
should be modified to deal correctly with the missing symbols.

I'll try and find some time in the next week to look at the version

albert chin (china thewrittenword com)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]